Page MenuHomeVyOS Platform
Create Task
Maniphest T1019

Enable Google BBR support at kernel compile time
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

Google BBR support comes builtin in kernel > 4.9 but needs to be enabled at compile time.

In VyOS to enable it just modify packages/vyos-kernel/arch/x86/configs/x86_64_vyos_defconfig

around line 940 uncomment

#CONFIG_TCP_CONG_BBR is not set

and set it

CONFIG_TCP_CONG_BBR=m

Then in VyOS you can switch to BBR by simply issuing system sysctl config commands

Details

Difficulty level
Easy (less than an hour)
Version
-
Why the issue appeared?
Will be filled on close

Related Objects

Event Timeline

agv created this task.Nov 16 2018, 10:03 AM
agv changed Difficulty level from Unknown (require assessment) to Easy (less than an hour).Nov 16 2018, 10:49 AM
agv updated the task description. (Show Details)Nov 16 2018, 10:53 PM
runar added a subscriber: runar.Nov 24 2018, 11:03 AM

Hmm, please enligthen me. Google BBR is a new way to handle congesition instead of the traditional way tcp deals with it. This functionallity needs to be enabled in the end host systems starting the tcp session to have any impact on troughput and congestion control.. as vyos is a router and are not responsible to start tcp sessions on behalf of any end system, what is the benefit of adding this functionallity?

c-po added a subscriber: c-po.Nov 24 2018, 3:09 PM

BBR was enabled in the latest commit to vyos-kernel

https://github.com/vyos/vyos-kernel/commit/58f4cc7a34a9d81bfe4d4164d265e7e448441595#diff-a4e386f2050362bb17242b190e9ab4d9R1007

c-po changed the task status from Open to In progress.Nov 24 2018, 3:10 PM
c-po claimed this task.
c-po triaged this task as Low priority.
syncer edited projects, added VyOS 1.2 Crux (VyOS 1.2.0-rc10); removed VyOS 1.2 Crux (VyOS 1.2.0-rc9).Nov 27 2018, 12:03 AM
dmbaturin closed this task as Resolved.Dec 4 2018, 12:48 AM
c-po mentioned this in T1081: GitHub Phabricator connection is broken.Dec 4 2018, 6:10 AM
syncer moved this task from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.0-rc10) board.Dec 5 2018, 11:58 PM
syncer added a project: VyOS-1.2.0-GA.Jan 25 2019, 2:38 PM
daniel.arconada added a subscriber: daniel.arconada.Mar 2 2022, 2:51 PM
In T1019#26665, @runar wrote:

Hmm, please enligthen me. Google BBR is a new way to handle congesition instead of the traditional way tcp deals with it. This functionallity needs to be enabled in the end host systems starting the tcp session to have any impact on troughput and congestion control.. as vyos is a router and are not responsible to start tcp sessions on behalf of any end system, what is the benefit of adding this functionallity?

Its is useful if you are starting a TCP session from the vyos for example when doing VPN.