Page MenuHomePhabricator

Obsolete "utc" option in time selector in firewall
Open, LowPublicBUG

Description

Hi!
In current version of VyOS exist utc option in firewall time:

vyos@vyos# set firewall name TESTFW1 rule 10 time 
Possible completions:
   monthdays    Monthdays to match rule on
   startdate    Date to start matching rule
   starttime    Time of day to start matching rule
   stopdate     Date to stop matching rule
   stoptime     Time of day to stop matching rule
   utc          Interpret times for startdate, stopdate, starttime and stoptime to be UTC
   weekdays     Weekdays to match rule on

This option generate --utc flag to rule.
Option was removed from iptables in 2011 and partially replaced by --kerneltz. But, to avoid problems with dates, I think we should just remove this part and note that all times must be set in UTC.

Details

Difficulty level
Easy (less than an hour)
Version
1.2.0-rolling+201812180337
Why the issue appeared?
Will be filled on close

Event Timeline

zsdc created this task.Dec 18 2018, 2:53 PM
syncer assigned this task to dmbaturin.Dec 21 2018, 10:25 AM
syncer triaged this task as Normal priority.
syncer edited projects, added VyOS 1.2 Crux ( VyOS 1.2.0-EPA); removed VyOS 1.2 Crux.
pasik added a subscriber: pasik.Dec 22 2018, 10:05 AM
syncer lowered the priority of this task from Normal to Low.