Page MenuHomePhabricator

Incorrect handling of tunnels without PFS by the "run show vpn ipsec sa" script
Closed, ResolvedPublicBUG

Description

Due to fragile SA spec regex the command fails with an exception if there are tunnels without PFS, because it expects the DH group field to be there.

vyos@vyos:~$ show vpn ipsec sa
Traceback (most recent call last):
File "/usr/libexec/vyos/op_mode/show_ipsec_sa.py", line 51, in <module>
raise e
File "/usr/libexec/vyos/op_mode/show_ipsec_sa.py", line 45, in <module>
bytes_in = hurry.filesize.size(int(bytes_in))
TypeError: int() argument must be a string or a number, not 'NoneType'

Details

Difficulty level
Easy (less than an hour)
Version
1.2.0-epa2
Why the issue appeared?
Implementation mistake
dmbaturin created this task.Jan 5 2019, 9:43 PM
dmbaturin claimed this task.
dmbaturin changed Why the issue appeared? from Will be filled on close to Implementation mistake.
dmbaturin added a subscriber: edong23.
pasik added a subscriber: pasik.Jan 8 2019, 4:47 PM
syncer closed this task as Resolved.
syncer moved this task from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.0-EPA3) board.
syncer triaged this task as Normal priority.