Page MenuHomePhabricator

/usr/libexec/vyos/conf_mode/host_name.py improvments
Open, Requires assessmentPublicFEATURE REQUEST

Description

  • doesn't check if a change is required to write to file. set system static-host-mapping has tag nodes, resolv.conf gets rewritten multiple times even if there is no change in resolv.conf required
  • add ....

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close

Event Timeline

hagbard created this task.Feb 22 2019, 9:12 PM
hagbard claimed this task.
pasik added a subscriber: pasik.Mar 12 2019, 6:06 PM

if host-name is not set and an IP is given to an interface script causes a an exception - maybe a default hostname could be set if the option is not in config.boot. Happens if you wipe config.boot and reboot. The default one won't have host-name configured and assigning IPs to interface still work but produce that nasty exception.

runar added a subscriber: runar.Apr 5 2019, 6:54 AM

When a host-name is not present, set the same default as on a newly installed device... router or vyos.. (atm. i don't remember what it says)

I think vyos is the default, so I'll weave it into host_name.py as a default if not present in the default config.boot. Not sure why there is that difference, but on the other hand the script should and can handle missing variables.

hagbard removed hagbard as the assignee of this task.Apr 16 2019, 9:41 PM