Page MenuHomePhabricator

bgp peer-groups don't work when "no-ipv4-unicast" is enabled.
Open, Requires assessmentPublic

Description

When trying to use peer-groups for neighbours, if you also have parameters default 'no-ipv4-unicast' set vyos will not create the neighbour:

Repro steps:

set protocols bgp 65400 parameters default 'no-ipv4-unicast'
set protocols bgp 65400 peer-group TEST remote-as '65401'
set protocols bgp 65400 neighbor 10.0.0.2 peer-group 'TEST'

Error:

[ protocols bgp 65400 ]
[ protocols bgp 65400 neighbor 10.0.0.2 ]
  peer-group defined but ipv4-unicast is disabled

Looks to be caused by a check here:

https://github.com/vyos/vyatta-cfg-quagga/blob/current/scripts/bgp/vyatta-bgp.pl#L1425

I'm not sure exactly why this check is there, it seems erroneous to me. Commenting out lines 1426 - 1428 seems to make vyos behave

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close