Page MenuHomePhabricator

Can't delete multiple OSPF passive-interfaces in single commit
Closed, ResolvedPublicBUG

Description

Using the following changed configuration:

vyos@vyos# show protocols
 ospf {
     area 0 {
         area-type {
             normal
         }
         authentication md5
         network xxx.yyy.150.112/28
     }
     parameters {
         abr-type cisco
         router-id xxx.yyy.150.253
     }
-    passive-interface default
-    passive-interface-exclude eth1
-    passive-interface-exclude eth2.5
     redistribute {
         connected {
             metric-type 2
             route-map MAP-OSPF-CONNECTED
         }
     }
 }

Results in:

vyos@vyos# commit
[ protocols ospf ]
For this router-id change to take effect, save config and restart ospfd

[ protocols ospf passive-interface default ]
sh: line 8: [: eth1: unary operator expected

but the change is accepted into the running configuration

Problem can be easy reproduced by:

set protocols ospf passive-interface default
set protocols ospf passive-interface-exclude eth1
set protocols ospf passive-interface-exclude eth2.5

commit

delete protocols ospf passive-interface default
delete protocols ospf passive-interface-exclude eth1
delete protocols ospf passive-interface-exclude eth2.5

commit

=> ERROR

Details

Difficulty level
Normal (likely a few hours)
Version
1.2.1
Why the issue appeared?
Will be filled on close

Event Timeline

c-po created this task.May 30 2019, 8:26 AM
c-po updated the task description. (Show Details)
c-po updated the task description. (Show Details)May 30 2019, 8:45 AM
c-po added a comment.May 30 2019, 8:48 AM

Adding some debug code to /opt/vyatta/share/vyatta-cfg/templates/protocols/ospf/passive-interface/node.def (set -x for delete) shows:

vyos@vyos# commit
[ protocols ospf passive-interface default ]
+ '[' -z default ']'
+ '[' default == default ']'
+ '[' eth1 eth2.5 ']'
sh: line 8: [: eth1: unary operator expected
+ vtysh -c 'configure terminal' -c 'router ospf' -c 'no passive-interface default'
c-po renamed this task from Error when deleting OSPF passive-interface/passive-interface-exclude to Can't delete multiple OSPF passive-interfaces in single commit.May 30 2019, 8:49 AM
c-po triaged this task as Normal priority.
c-po updated the task description. (Show Details)
c-po closed this task as Resolved.May 30 2019, 9:03 AM
c-po claimed this task.
c-po updated the task description. (Show Details)
c-po added a project: VyOS 1.3 Equuleus.
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.May 30 2019, 9:08 AM
c-po moved this task from Need Triage to VyOS 1.2.2 on the VyOS 1.2 Crux board.
c-po edited projects, added VyOS 1.2 Crux (VyOS 1.2.2); removed VyOS 1.2 Crux.
c-po moved this task from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.2) board.