Page MenuHomePhabricator

Creating two DHCPv6 shared-network-names with the same subnet is allowed, causes dhcpd to fail to start.
Backport candidate, Requires assessmentPublicBUG

Description

The validator should check for multiple declarations of the same subnet under different shared-network-names. This can happen after f.e. renaming one shared-network-name to a new name and mistakenly applying a history command to the old name, causing the old name to be recreated alongside the new one.

rename shared-network-name test-pool to shared-network-name test-6pool
set shared-network-name test-pool subnet 2001:db8::/64
commit

Details

Difficulty level
Unknown (require assessment)
Version
1.2.0-rolling+201905261657
Why the issue appeared?
Will be filled on close

Event Timeline

jjakob created this task.Jun 16 2019, 1:49 PM
pasik added a subscriber: pasik.Jun 18 2019, 8:27 AM

I would be wary of including it in Crux, since it's a behaviour change.

Also, most of the validations are the same for IPv4 and IPv6 and shouldn't be duplicated I think.

dmbaturin changed the task status from Open to Backport candidate.Jul 18 2019, 10:05 PM

Even if it was allowed, dhcpd would fail to start with the generated config so it shouldn't be a problem? Unless some had their invalid config kept even with broken dhcp-server, which I doubt.
It would be fixed first in current, of course. It's not a priority for me so I won't be tackling it.