Page MenuHomePhabricator

Deleting 'firewall options' causes Python TypeError
Closed, ResolvedPublicBUG

Description

Deleteing the following firewall rules triggered an error:

firewall {
    all-ping enable
    broadcast-ping disable
    config-trap disable
    ipv6-receive-redirects disable
    ipv6-src-route disable
    ip-src-route disable
    log-martians enable
    options {
        interface wg01 {
            adjust-mss 1352
        }
    }
    receive-redirects disable
    send-redirects enable
    source-validation disable
    syn-cookies enable
    twa-hazards-protection disable
}
vyos@vyos# commit

[ firewall options interface wg01 ]
Traceback (most recent call last):
  File "/usr/libexec/vyos/conf_mode/firewall_options.py", line 139, in <module>
    apply(c)
  File "/usr/libexec/vyos/conf_mode/firewall_options.py", line 97, in apply
    if tcp['new_chain4']:
TypeError: 'NoneType' object is not subscriptable

delete [ firewall options ] failed
delete [ firewall ] failed
Commit failed
[edit]

Details

Difficulty level
Easy (less than an hour)
Version
1.2.1-S2
Why the issue appeared?
Implementation mistake

Event Timeline

c-po created this task.Jun 20 2019, 8:09 PM
c-po renamed this task from Deleting firewall causes Python TypeError to Deleting 'firewall options' causes Python TypeError.Jun 20 2019, 8:15 PM
c-po closed this task as Resolved.
c-po claimed this task.
c-po triaged this task as High priority.
c-po changed Difficulty level from Unknown (require assessment) to Easy (less than an hour).
c-po changed Why the issue appeared? from Will be filled on close to Implementation mistake.
syncer moved this task from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.2) board.
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.