Page MenuHomePhabricator

Rewrite Bridge in new style XML syntax
Closed, ResolvedPublicFEATURE REQUEST

Description

This a bit identical to the rewrite of VRRP.

We have a top level bridge node and then each individual interface has an additional bridge section. So the configuration is split among multiple nodes.

bridge br0 {
    address 192.0.2.254/24
    stp true
}
ethernet eth0 {
    bridge-group {
        bridge br0
        cost 10
        priority 20
    }
ethernet eth1 {
    bridge-group {
        bridge br0
        cost 10
        priority 20
    }
}

I propose an alternative CLI style:

bridge br0 {
    address 192.0.2.254/24
    stp true
    interface eth0 {
        cost 10
        priority 20
    }
    interface eth1 {
        cost 10
        priority 20
    }
}

or

bridge br0 {
    address 192.0.2.254/24
    stp true
    member eth0 {
        cost 10
        priority 20
    }
    member eth1 {
        cost 10
        priority 20
    }
}

TODO:

  • replace boolean node by valueless node set interfaces bridge br0 stp true|false -> set interfaces bridge br0 stp to enable STP
  • replace boolean node by valueless node set interfaces bridge br0 igmp-snooping querier enable|disable -> set interfaces bridge br0 igmp-snooping querier to enable IGMP querier
  • update documentation

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close

Event Timeline

c-po removed c-po as the assignee of this task.Aug 1 2019, 8:17 AM
c-po updated the task description. (Show Details)
c-po renamed this task from Rewrite OpenVPN interface in new style XML syntax to Rewrite Bridge in new style XML syntax.Aug 1 2019, 9:59 AM
c-po claimed this task.Aug 2 2019, 8:44 AM
c-po updated the task description. (Show Details)
c-po changed the task status from Open to Needs testing.Aug 5 2019, 10:33 AM
c-po updated the task description. (Show Details)Aug 5 2019, 1:33 PM
c-po updated the task description. (Show Details)Aug 5 2019, 1:52 PM
pasik added a subscriber: pasik.Aug 5 2019, 9:18 PM
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Aug 17 2019, 12:41 AM
jjakob added a subscriber: jjakob.Aug 24 2019, 9:34 PM

The interface/0-to-1 migration script is failing on upgrade (T1611).