Page MenuHomePhabricator

Adopt WireGuard configuration script to new vyos.ifconfig class
Closed, ResolvedPublicFEATURE REQUEST

Description

Instead of generating the interface configuration commands by hand, make use of vyos.ifconfig like it is done in bridge, loopback, dummy and soon bonding interface.

While doing this transition it should also be made use of the VYOS_TAGNODE_VALUE environment variable so the interface-wireguard.py script is only run for the specified tag node and not on all tag nodes.

This results in only the interface which had changes in the CLI will be changed. All other WireGuard interfaces are not processed.

Details

Difficulty level
Hard (possibly days)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible

Event Timeline

c-po assigned this task to hagbard.Sep 3 2019, 12:01 PM
c-po triaged this task as Normal priority.
c-po created this task.
c-po changed Difficulty level from Unknown (require assessment) to Normal (likely a few hours).

That will be a complete rewrite, since the interface name is now readable via VYOS_TAGNODE_VALUE, that affects get_config() quite a lot and will reduce the number of code line significantly. The flip side of the coin is, that the current code was running pretty reliable, so I will release small updates while adopting to see if I break anything configure outside of my test environment.

hagbard changed Difficulty level from Normal (likely a few hours) to Hard (possibly days).Sep 3 2019, 6:12 PM
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Sun, Oct 13, 3:05 PM