Page MenuHomePhabricator

equuleus: buster: arm: vyos-accel-ppp build failes because of filename hardcoded as x86_64 in debian/rules
Closed, ResolvedPublicENHANCEMENT

Description

in debian/rules for this package there is hardcoded dependencies to x86_64, this makes compiling this package on arm impossible
rule lines:

debian/rules:	cp obj-x86_64-linux-gnu/drivers/ipoe/driver/ipoe.ko debian/tmp/lib/modules/4.19.58-amd64-vyos/extra/
debian/rules:	cp obj-x86_64-linux-gnu/drivers/vlan_mon/driver/vlan_mon.ko debian/tmp/lib/modules/4.19.58-amd64-vyos/extra/
debian/rules:	dh_auto_clean -- rm -rf obj-x86_64-linux-gnu

this directory is on my armhf called: obj-arm-linux-gnueabihf

a way to reproduce is to build the reository on an armhf system, eg. raspberry pi

Details

Difficulty level
Normal (likely a few hours)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible

Event Timeline

runar triaged this task as Normal priority.Thu, Sep 12, 7:56 AM
runar created this task.
hagbard claimed this task.Thu, Sep 12, 3:26 PM
hagbard changed the task status from Open to In progress.Thu, Sep 12, 3:32 PM
hagbard changed Difficulty level from Unknown (require assessment) to Normal (likely a few hours).Thu, Sep 12, 9:11 PM
Dmitry added a subscriber: Dmitry.Fri, Sep 13, 8:30 AM
hagbard changed the task status from In progress to Needs testing.Fri, Sep 13, 3:44 PM

@runar
I just cross compiled it successfully. CI uses a sed right now to correct it, all paths are now generic.
What I currently can't do is actually testing the binaries on a real device, I would appreciate it if you can do that.

All packages can be cross compiled with no issues on a Deb10 (Use ARCH=arm for Kernel prp and then dpkg-buildpackage -a armhf -b -tc -us -uc ):
dpkg-deb: building package 'vyos-accel-ppp' in '../vyos-accel-ppp_1.11.2-11_armhf.deb'.
dpkg-deb: building package 'vyos-accel-ppp-ipoe-kmod' in '../vyos-accel-ppp-ipoe-kmod_1.11.2-11_armhf.deb'.
dpkg-deb: building package 'vyos-accel-ppp-dbgsym' in '../vyos-accel-ppp-dbgsym_1.11.2-11_armhf.deb'.
dpkg-deb: building package 'vyos-accel-ppp-doc' in '../vyos-accel-ppp-doc_1.11.2-11_all.deb'.

Pushed to equuleus only for now: https://github.com/vyos/vyos-accel-ppp/tree/equuleus

pushed to current too and rebuilt kernel in CI successfully.

hagbard closed this task as Resolved.Fri, Sep 13, 7:47 PM