Page MenuHomePhabricator

vif bridge-group not migrated to bridge member interface
Open, Requires assessmentPublicBUG

Description

The bridge-group setting has gone missing from vif interfaces.

Details

Difficulty level
Normal (likely a few hours)
Version
vyos-1.2-rolling-201909190545
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Config syntax change (migratable)

Event Timeline

mb300sd created this task.Sep 19 2019, 6:51 PM

Just noticed bridge has a member interface parameter now. The vif bridge-group config was not migrated.

mb300sd changed Is it a breaking change? from Behavior change to Config syntax change (migratable).Sep 19 2019, 6:55 PM
mb300sd renamed this task from bridge-group missing from vif to vif bridge-group not migrated to bridge member interface.Sep 19 2019, 6:59 PM

After adding the vif to bridge member interfaces, I get a config load error on boot. Running config, load, commit, works. Something to do with the order the configs get applied?

mb300sd added a comment.EditedSep 19 2019, 7:56 PM

The loading error is caused by bridging a l2tpv3 interface, didn't see the cause at first because of the other errors. Since the bridge is now created at priority 470, and l2tpv3 is 800, when before an interface would be added to the bridge as it is created.

Perhaps a fix could be changing it to
bridge brX member interface <type> <if>
with different priorities for the types?

c-po added a subscriber: c-po.Sep 19 2019, 8:16 PM

Please share a pre and post-commit config block for me for testing.

You are right the VIF parts have been forgotten on the VIF interfaces

c-po claimed this task.Sep 19 2019, 8:16 PM
c-po edited projects, added VyOS 1.3 Equuleus; removed VyOS 1.2 Crux.
c-po changed Difficulty level from Unknown (require assessment) to Normal (likely a few hours).

Not sure what you mean by pre and post-commit config blocks.

I can reproduce with minimal config on a freshly installed vm.

Config screenshot.. no network on it. https://i.imgur.com/A0mwPdI.png

Reboot - config error, bridge is missing. config/load/commit and the bridge is created.

c-po added a comment.EditedSep 20 2019, 6:03 AM

Please add the config here as text so it can be easily extracted. Image hosting services tend to not store information forever.

Pre config: add configuration from VyOS (e.g. 1.2.2) which has the VIF interface added before upgrading to latest rolling. That one can be used in the lab to reproduce your problem exactly.

c-po moved this task from Need Triage to Backlog on the VyOS 1.3 Equuleus board.Tue, Nov 12, 9:20 PM