Nope, I was talking about completionHelper, which is not implemented - same as constraint nodes for udp/tcp regex.

https://github.com/vyos/vyos-1x/blob/crux/interface-definitions/syslog.xml#L286-L298

There is a difference in valueHelp and completionHelp. valueHelp shows whats possible and completionHelp will conplete the CLI command once you hit TAB.

Example: https://github.com/vyos/vyos-1x/blob/current/interface-definitions/interfaces-wireless.xml#L164-L183

Thanks, should be backported to crux then as I found it there

Will interfere with T1845, while I think T1845 should be the backport candidate. Facility is a tag node, protocol has been moved on level up and is host specific. Having the availability to set different port per facility doesn't really make sense.

Wha cant the change which adds the completion helper be backported? Git best practice is you should group changes per commit. But in this commit you add the completion helper and also other regexes (BAD!)

You can via https://github.com/vyos/vyos-1x/commit/dad110ce666edae42ac18c59a800bda503589f27, which just sets the completion help.
For T1845, yes it solves the issue with setting address:port _and_ moves protocol up from facility to host. Do you want me to revert and do 2 commits, which requires then 2 migrations, once for address:port and one to solve the logical issue with protocol. Right now you can set a different protocol for different facilities for the same host.

@hagbard @c-po what we do with that? moving to 1.2.6?

@syncer https://github.com/vyos/vyos-1x/commit/dad110ce666edae42ac18c59a800bda503589f27 are only CLI modifications (validation to be be precise), no code changes at all which would change the functionality, in my opinion it can be backported as is.