Page MenuHomePhabricator

PPPoE unrecognized option 'replacedefaultroute'
Open, Requires assessmentPublicBUG

Description

The following configuration throws the above error:

 ethernet eth2 {
     duplex auto
     hw-id 00:0d:b9:53:07:ee
     smp-affinity auto
     speed auto
+    vif 7 {
+        pppoe 0 {
+            default-route force
+            mtu 1300
+            name-server auto
+            password 123456789
+            user-id vyos@vyos.io
+        }
+    }
 }

Generates the log entry:

Dec  1 11:16:37 LR4 pppd[8954]: Plugin rp-pppoe.so loaded.
Dec  1 11:16:37 LR4 pppd[8954]: RP-PPPoE plugin version 3.8p compiled against pppd 2.4.7
Dec  1 11:16:37 LR4 pppd[8954]: In file /etc/ppp/peers/pppoe0: unrecognized option 'replacedefaultroute'

Reproduce

set interfaces ethernet eth2 vif 7 pppoe 0 default-route 'force'
set interfaces ethernet eth2 vif 7 pppoe 0 link 'eth2'
set interfaces ethernet eth2 vif 7 pppoe 0 mtu '1300'
set interfaces ethernet eth2 vif 7 pppoe 0 name-server 'auto'
set interfaces ethernet eth2 vif 7 pppoe 0 password '123456789'
set interfaces ethernet eth2 vif 7 pppoe 0 user-id 'vyos@vyos.io'

Generated config /etc/ppp/peers/pppoe0

noipdefault
hide-password
lcp-echo-interval 20
lcp-echo-failure 3
noaccomp
default-asyncmap
connect /bin/true
noauth
noproxyarp
plugin rp-pppoe.so
eth2.7
persist
ipparam pppoe0
debug
logfile /var/log/vyatta/ppp_pppoe0.log
defaultroute 
replacedefaultroute
usepeerdns
password "123456789"
user "vyos@vyos.io"
mtu 1400
mru 1400

Details

Difficulty level
Unknown (require assessment)
Version
1.2.3
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible

Event Timeline

c-po created this task.Sun, Dec 1, 10:04 AM
c-po added a comment.Sun, Dec 1, 10:17 AM

As noone complained that this option is not working (and it is an extension to regular ppp) I propose to remove it.

https://github.com/vyos/ppp-debian/search?q=replacedefaultroute&unscoped_q=replacedefaultroute

https://bugs.gentoo.org/227321

By removing this - we could make use of ppp from Debian upstream in equuleus

c-po updated the task description. (Show Details)Sun, Dec 1, 10:20 AM
hagbard added a subscriber: hagbard.Sun, Dec 1, 9:40 PM

https://phabricator.vyos.net/T1228 sent the bug and I backported from upstream . The PR is in T1228 but needs to be merged into our package which I don't have permissions for.

pasik added a subscriber: pasik.Mon, Dec 2, 9:24 AM