Page MenuHomeVyOS Platform

accel-ppp: pppoe single-session option implementation
Closed, ResolvedPublicBUG

Description

Hello!
Please also add "single-session" to
set service pppoe-server ppp-options

From accel-ppp docs:
single-session=replace|deny
Specifies whether to control sessions count.
If this option is absent session count control is turned off.
If this option is replace then accel-ppp will terminate first session when second is authorized.
If this option is deny then accel-ppp will deny second session authorization.

Details

Difficulty level
Normal (likely a few hours)
Version
1.3
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Feature (new functionality)

Event Timeline

hagbard added a subscriber: hagbard.

Hi,

per default session=replace is set and if I understand correctly you'd like to have to have the option to change it to deny don't set it at all. Is that correct?

https://github.com/vyos/vyos-1x/blob/current/src/conf_mode/accel_pppoe.py#L185

hagbard changed the task status from Open to In progress.Dec 16 2019, 3:37 PM
hagbard triaged this task as Normal priority.
hagbard changed Difficulty level from Unknown (require assessment) to Normal (likely a few hours).
hagbard renamed this task from accel-ppp: pppoe single-session to accel-ppp: pppoe single-session option implementation.Dec 16 2019, 3:52 PM
hagbard changed the task status from In progress to Needs testing.Dec 16 2019, 4:59 PM

https://github.com/vyos/vyos-1x/commit/b55b68f6246329468b4ab3450e127d5bab683bff or tomorrows rolling release will have it included. I keept the default 'replace' and you can chose between deny or disable, while disable removes the option entirely from the accel config, which I wouldn't recommend to do.

@fcqpl any chance to test it in your environment?

erkin set Issue type to Feature (new functionality).Aug 31 2021, 6:06 PM