Page MenuHomeVyOS Platform
Create Task
Maniphest T1933

Changes in /config/scripts/vyos-postconfig-bootup.script got lost during upgrade to 1.2.4
Closed, InvalidPublicBUG
Actions

Description

hi,

I execute a script on postconfig by adding it to /config/scripts/vyos-postconfig-bootup.script.
After upgrade from 1.2.3 -> 1.2.4 the changes got lost and the file looks orginal.

Before Upgrade:

#!/bin/sh
# This script is executed at boot time after VyOS configuration is fully applied.
# Any modifications required to work around unfixed bugs
# or use services not available through the VyOS CLI system can be placed here.
/config/scripts/rcs/rcs-mgnt-vlan.sh 2>/dev/null 1>/dev/null

After:

#!/bin/sh
# This script is executed at boot time after VyOS configuration is fully applied.
# Any modifications required to work around unfixed bugs
# or use services not available through the VyOS CLI system can be placed here.

Details

Difficulty level
Unknown (require assessment)
Version
1.2.4
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

rherold created this task.Jan 2 2020, 10:26 AM
rherold added a comment.Jan 2 2020, 11:13 AM

I got this on two production systems on the next two I migrated I changed my workflow to:

add system image ****
configure
save
reboot

On this systems I did not have the problem.

syncer changed the task status from Open to Needs testing.Jan 6 2020, 12:26 AM
syncer assigned this task to Unknown Object (User).
syncer triaged this task as High priority.
syncer edited projects, added VyOS 1.3 Equuleus, VyOS 1.2 Crux (VyOS 1.2.5); removed VyOS 1.2 Crux.
Unknown Object (User) added a comment.EditedJan 6 2020, 8:38 AM

Hi @rherold , I can't create this behaviour in LAB.
I have clear vyos-1.2.3 installed and do next steps:

  1. sudo nano /config/scripts/vyos-postconfig-bootup.script
#!/bin/sh
# This script is executed at boot time after VyOS configuration is fully applie$
# Any modifications required to work around unfixed bugs
# or use services not available through the VyOS CLI system can be placed here.
/config/scripts/rcs/rcs-mgnt-vlan.sh 2>/dev/null 1>/dev/null
  1. sudo mkdir /config/scripts/rcs/
  2. Create file sudo nano /config/scripts/rcs/rcs-mgnt-vlan.sh with following commands
#!/bin/bash

echo "test script" >> /tmp/migration.log
date >> /tmp/migration.log
  1. Add permission for execution sudo chmod +x /config/scripts/rcs/rcs-mgnt-vlan.sh
  2. Run reboot for confirm execution scripts and check output file in /tmp
vyos@test6:~$ cat /tmp/migration.log 
test script
Mon Jan  6 08:25:29 UTC 2020
  1. Update to 1.2.4 - add system image ...
  2. Reboot

All was migrated as expected and scripts runs. Can you explain how I can reach described behaviour?

pasik added a subscriber: pasik.Jan 6 2020, 12:26 PM
Unknown Object (User) added a comment.Mar 13 2020, 3:02 PM

@rherold do you have any additional info how I can reproduce this issue?

syncer lowered the priority of this task from High to Normal.Mar 15 2020, 10:59 PM
syncer removed a project: VyOS 1.2 Crux (VyOS 1.2.5).
Unknown Object (User) closed this task as Invalid.May 26 2020, 3:59 PM
c-po moved this task from Need Triage to Backlog on the VyOS 1.3 Equuleus board.Jun 2 2020, 5:48 PM
c-po moved this task from Backlog to Finished on the VyOS 1.3 Equuleus board.Jun 2 2020, 7:36 PM
erkin set Issue type to Bug (incorrect behavior).Aug 31 2021, 5:58 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 30 2022, 2:01 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.