Page MenuHomePhabricator

vyos-http-api-server should reload Config in all routes
Closed, ResolvedPublicBUG

Description

With the optimization in T1758, the bottle app entry for config will contain the session configuration as it was during server initialization; consequently, a 'set' operation followed by a 'returnValue' operation will not show updated values. In the 'retrieve' route, call the Config constructor from the session, in order to return current values. Moreover, this will apply to the 'configure' path as well, which checks for existence on 'delete'. No other routes currently use config.py, but any future additions should follow this practice.

Details

Difficulty level
Easy (less than an hour)
Version
vyos-1.3
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible

Event Timeline

jestabro changed the task status from Open to In progress.Fri, Feb 14, 3:58 PM
jestabro claimed this task.
jestabro created this task.
jestabro renamed this task from vyos-http-api-server should reload Config in route retrieve to vyos-http-api-server should reload Config in all routes.Fri, Feb 14, 4:03 PM
jestabro closed this task as Resolved.Fri, Feb 14, 5:47 PM
jestabro moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.