Page MenuHomeVyOS Platform

traffic-policy shaper error when setting bandwidth
Closed, ResolvedPublic

Description

Hi, Changing the shaper bandwidth is now throwing an error.

set traffic-policy shaper myshaper-out bandwidth 6000kbit

I get:

[ traffic-policy shaper myshaper-out ]
Use of uninitialized value in concatenation (.) or string at /opt/vyatta/sbin/vyatta-qos.pl line 249.

traffic-policy {
    shaper myshaper-out {
        bandwidth 6000kbit
        class 2 {
            bandwidth 30%
            burst 50kb
            ceiling 100%
            description "Syn ack bufferbloat out"
            match tiny4 {
                ip {
                    max-length 256
                    tcp {
                        ack
                        syn
                    }
                }
            }
            match tiny6 {
                ip {
                    max-length 256
                    tcp {
                        ack
                        syn
                    }
                }
            }
            queue-type fq-codel
        }
        default {
            bandwidth 70%
            burst 250kb
            ceiling 100%
            queue-type fq-codel
        }
    }
}

    pppoe pppoe0 {
        authentication {
            password ******
            user bthomehub@btbroadband.com
        }
        default-route auto
        mtu 1500
        no-peer-dns
        source-interface eth3
        traffic-policy {
            out myshaper-out
        }
    }

Details

Difficulty level
Unknown (require assessment)
Version
1.3-rolling-202002280217
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

SteveP created this object in space S1 VyOS Public.
c-po changed the task status from Open to In progress.Feb 28 2020, 1:40 PM
c-po claimed this task.
c-po triaged this task as Normal priority.
c-po added a project: VyOS 1.3 Equuleus.

As PPPoE is now denested the logic in Vyatta::Interfaces needs to be adjusted

erkin set Issue type to Bug (incorrect behavior).Aug 31 2021, 5:29 PM