Page MenuHomeVyOS Platform

WireGuard broken after merging T2057
Closed, ResolvedPublicBUG

Description

Configuration

cpo@BR1.wue3# show interfaces wireguard  | strip-private
+wireguard wg02 {
+    address xxx.xxx.252.69/30
+    ip {
+        ospf {
+            cost 200
+            dead-interval 40
+            hello-interval 10
+            network point-to-point
+            priority 1
+            retransmit-interval 5
+            transmit-delay 5
+        }
+    }
+    mtu 1360
+    peer xxxxx.tld {
+        allowed-ips xxx.xxx.0.0/0
+        endpoint xxx.xxx.151.218:7701
+        pubkey <...>
+    }
+    port 7701
+}
+wireguard wg05 {
+    address xxx.xxx.252.73/30
+    ip {
+        ospf {
+            dead-interval 40
+            hello-interval 10
+            network point-to-point
+            priority 1
+            retransmit-interval 5
+            transmit-delay 5
+        }
+    }
+    mtu 1360
+    peer xxxxx.tld {
+        allowed-ips xxx.xxx.0.0/0
+        endpoint xxx.xxx.69.205:7705
+        pubkey <...>
+    }
+    port 7705
+}

Commit

vyos@vyos# commit
[ interfaces wireguard wg02 ]
invalid option port for <class 'vyos.ifconfig.WireGuardIf'>

[[interfaces wireguard wg02]] failed
[ interfaces wireguard wg05 ]
invalid option port for <class 'vyos.ifconfig.WireGuardIf'>

[[interfaces wireguard wg05]] failed
[[interfaces wireguard wg05 ip ospf]] failed
[[interfaces wireguard wg02 ip ospf]] failed
Commit failed

Error is most likely introduced by https://github.com/vyos/vyos-1x/pull/227 as this was the last change to ifconfig.py

Details

Difficulty level
Unknown (require assessment)
Version
1.3-rolling-202002281700
Why the issue appeared?
Implementation mistake
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

c-po triaged this task as Unbreak Now! priority.
c-po created this task.

All my apologies for this stupid bug.

fixed with:
https://github.com/vyos/vyos-1x/pull/231

ran smoketest on local setup (which is not 100% identical to the one expected) and change works.

thomas-mangin changed the task status from Open to In progress.Feb 29 2020, 1:09 AM
c-po changed Why the issue appeared? from Will be filled on close to Implementation mistake.
erkin set Issue type to Bug (incorrect behavior).Aug 31 2021, 5:29 PM