Page MenuHomeVyOS Platform
Create Task
Maniphest T2090

Deleting 'service salt-minion' causes python TypeError
Closed, ResolvedPublic
Actions

Description

Deleting the following triggers an error.

salt-minion {
     id router.ad.raeven.net
     master 10.1.20.8
 }
Traceback (most recent call last):
  File "/usr/libexec/vyos/conf_mode/salt-minion.py", line 199, in <module>
    generate(c)
  File "/usr/libexec/vyos/conf_mode/salt-minion.py", line 150, in generate
    uid = pwd.getpwnam(salt['user']).pw_uid
TypeError: 'NoneType' object is not subscriptable

Details

Difficulty level
Unknown (require assessment)
Version
VyOS 1.2.5-epa1
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)

Event Timeline

Raeven created this task.Mar 2 2020, 2:17 PM
Raeven created this object in space S1 VyOS Public.
pasik added a subscriber: pasik.Mar 2 2020, 10:08 PM
dmbaturin added projects: VyOS 1.2 Crux, VyOS 1.3 Equuleus.Jun 25 2020, 5:32 AM
Viacheslav added a subscriber: Viacheslav.Aug 11 2020, 6:09 AM

Fixed int the latest rolling, VyOS 1.3-rolling-202008110118

vyos@r2-roll# set service salt-minion id 'my.router.id'
[edit]
vyos@r2-roll# set service salt-minion master '10.0.0.2'
[edit]
vyos@r2-roll# commit
[edit]
vyos@r2-roll# delete service salt-minion 
[edit]
vyos@r2-roll# commit
[edit]
vyos@r2-roll# run show version 

Version:          VyOS 1.3-rolling-202008110118
c-po closed this task as Resolved.Aug 16 2020, 7:02 PM
c-po claimed this task.
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Nov 23 2020, 5:23 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 12:26 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.