The PR in question is here: https://github.com/vyos/vyos-build/pull/98
Please review/merge?
This PR resolves an issue where the build-vmware-image script ignores the predefined file path, uses the environment variable unconditionally.
Thanks!
The PR in question is here: https://github.com/vyos/vyos-build/pull/98
Please review/merge?
This PR resolves an issue where the build-vmware-image script ignores the predefined file path, uses the environment variable unconditionally.
Thanks!
Thanks, Yuriy.
Did I do the wrong thing by tagging this for vyos-build?
I was planning on submitting another PR that (at least partially) eliminates the dependency on ovftool. If I'm getting the etiquette wrong, I'd like to know.
Not really, just make sure you include VyOS 1.3 project so we can track what can be backported
you will need to adjust your PR message to include task number T2239
@chrismarget we autogenerate list of resolved issues for releases
so tasks names should be with more context
Looks good. I don't have merge access but this definitely is a fix to an oversight in the build.