The use of vyos.util cmd from T2226 in vyos-merge-config and vyos.remote was incorrect, and needs to be revisited.
Description
Description
Details
Details
- Difficulty level
- Unknown (require assessment)
- Version
- vyos-1.3
- Why the issue appeared?
- Will be filled on close
- Is it a breaking change?
- Perfectly compatible
- Issue type
- Internal change (not visible to end users)
Related Objects
Related Objects
- Mentioned Here
- T2226: unify all the ways commands are run
Event Timeline
Comment Actions
fingerprint = cmd(fingerprint_cmd, shell=True, stderr=DEVNULL)
I have converted this to
fingerprint = cmd(fingerprint_cmd, stderr=DEVNULL, input=input=host_key)
As the code had the input previous and I did not want to break anythin (having it should be harmless if it was a oversight.
shell=True is automatic if you have any space in the command :-)
(I had a merge conflict with some of my own work)