Page MenuHomeVyOS Platform

Fix use of cmd in merge config and remote function helpers
Closed, ResolvedPublic

Description

The use of vyos.util cmd from T2226 in vyos-merge-config and vyos.remote was incorrect, and needs to be revisited.

Details

Difficulty level
Unknown (require assessment)
Version
vyos-1.3
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Event Timeline

jestabro triaged this task as Normal priority.Apr 9 2020, 5:14 AM
jestabro created this task.
jestabro created this object in space S1 VyOS Public.
jestabro renamed this task from Fix use of cmd in vyos merge and remote function helper to Fix use of cmd in merge config and remote function helpers.Apr 9 2020, 5:19 AM
jestabro moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.
fingerprint = cmd(fingerprint_cmd, shell=True, stderr=DEVNULL)

I have converted this to

fingerprint = cmd(fingerprint_cmd,  stderr=DEVNULL, input=input=host_key)

As the code had the input previous and I did not want to break anythin (having it should be harmless if it was a oversight.
shell=True is automatic if you have any space in the command :-)

(I had a merge conflict with some of my own work)

erkin set Issue type to Bug (incorrect behavior).Mon, Aug 30, 7:17 AM
erkin changed Issue type from Bug (incorrect behavior) to Internal change (not visible to end users).
erkin removed a subscriber: Active contributors.