Page MenuHomeVyOS Platform
Create Task
Maniphest T2262

Broken reset commands for pptp and l2tp
Closed, ResolvedPublicBUG
Actions

Description

vyos@RTR1:~$ reset vpn remote-access all 
Traceback (most recent call last):
  File "/usr/libexec/vyos/op_mode/reset_vpn.py", line 86, in <module>
    main()
  File "/usr/libexec/vyos/op_mode/reset_vpn.py", line 77, in main
    terminate_sessions(username=args.username, interface=args.interface, protocol=args.protocol)
  File "/usr/libexec/vyos/op_mode/reset_vpn.py", line 40, in terminate_sessions
    run(pptp_cmd, stdout=DEVNULL, stderr=DEVNULL)
  File "/usr/lib/python3/dist-packages/vyos/util.py", line 65, in run
    decode=decode,
  File "/usr/lib/python3/dist-packages/vyos/util.py", line 48, in popen
    tmp = p.communicate(input, timeout)[0].strip()
AttributeError: 'NoneType' object has no attribute 'strip'

Details

Difficulty level
Normal (likely a few hours)
Version
1.3-rolling-202004090554
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

Unknown Object (User) changed the task status from Open to In progress.Apr 10 2020, 12:23 PM
Unknown Object (User) claimed this task.
Unknown Object (User) created this task.
Unknown Object (User) updated the task description. (Show Details)
Unknown Object (User) added a comment.Apr 10 2020, 6:18 PM

PR https://github.com/vyos/vyos-1x/pull/324

Unknown Object (User) changed the task status from In progress to Needs testing.Apr 11 2020, 6:59 AM
pasik added a subscriber: pasik.Apr 11 2020, 9:31 AM
Unknown Object (User) closed this task as Resolved.Apr 12 2020, 6:09 PM
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.May 21 2020, 5:26 PM
erkin set Issue type to Bug (incorrect behavior).Aug 30 2021, 7:14 AM
erkin removed a subscriber: Active contributors.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 30 2022, 2:01 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.