Page MenuHomeVyOS Platform

DHCP to be an attribute of the class instead of a inheritance
Closed, ResolvedPublicFEATURE REQUEST


The code current has DHCP as a subclass of interface (it was broken down from Interface itself to make it easier to read).
None of the CODE of DHCP is relying on anything in Interface, therefore it would make sense to have the DHCP code under a "self.dhcp" in the class.


Difficulty level
Unknown (require assessment)
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)

Event Timeline

thomas-mangin renamed this task from Move DHCP from inside Interface to DHCP to be an attribute of the class instead of a inheritance.Apr 10 2020, 9:36 PM
thomas-mangin closed this task as Resolved.
thomas-mangin claimed this task.
pasik added a subscriber: pasik.Apr 11 2020, 9:31 AM
thomas-mangin added a comment.EditedApr 11 2020, 12:18 PM

The works also include the migration of template to separate files as per T2230

c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Thu, May 21, 5:26 PM