Page MenuHomeVyOS Platform
Create Task
Maniphest T2265

DHCP to be an attribute of the class instead of a inheritance
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

The code current has DHCP as a subclass of interface (it was broken down from Interface itself to make it easier to read).
None of the CODE of DHCP is relying on anything in Interface, therefore it would make sense to have the DHCP code under a "self.dhcp" in the class.

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Internal change (not visible to end users)

Related Objects

Event Timeline

thomas-mangin created this task.Apr 10 2020, 4:34 PM
thomas-mangin mentioned this in T2268: DHCPv6 is broken.Apr 10 2020, 9:35 PM

https://github.com/vyos/vyos-1x/pull/326

thomas-mangin renamed this task from Move DHCP from inside Interface to DHCP to be an attribute of the class instead of a inheritance.Apr 10 2020, 9:36 PM
thomas-mangin closed this task as Resolved.
thomas-mangin claimed this task.
pasik added a subscriber: pasik.Apr 11 2020, 9:31 AM
thomas-mangin added a comment.EditedApr 11 2020, 12:18 PM

The works also include the migration of template to separate files as per T2230

c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.May 21 2020, 5:26 PM
erkin set Issue type to Internal change (not visible to end users).Aug 30 2021, 7:14 AM
erkin removed a subscriber: Active contributors.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 30 2022, 2:01 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.