Page MenuHomeVyOS Platform

Create XML scheme for [conf_mode] BGP
Closed, ResolvedPublicFEATURE REQUEST

Description

Required XML for [conf_mode] BGP.

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Internal change (not visible to end users)

Event Timeline

PR https://github.com/vyos/vyos-1x/pull/378

It's the only XML for BGP [conf_mode].
The syntax of all commands remains the same.
This XML also needs a python handler.
Its code will replace the nodes of the templates in https://github.com/vyos/vyatta-cfg-quagga/tree/current/templates/protocols/bgp in the future.

Because the process of writing a python handler is not fast, I did

set protocol nbgp

instead of

set protocol bgp

To compare everything and test more precisely with the old scheme.

# set protocols nbgp 234 
Possible completions:
 > address-family
                BGP address-family parameters
 > maximum-paths
                BGP multipaths
+> neighbor     BGP neighbor
 > parameters   BGP parameters
+> peer-group   BGP peer-group
   route-map    Filter routes installed in local route map
 > timers       BGP protocol timers
Viacheslav changed the task status from Open to Needs testing.May 22 2020, 4:57 PM
  1. Unable to set value for "unsuppress-map", afi ipv4 + ipv6

Expect:

set protocols nbgp 65001 neighbor 10.0.0.1 address-family ipv4-unicast unsuppress-map RMAP

Get:

vyos@r4-roll# set protocols nbgp 65001 neighbor 10.0.0.1 address-family ipv4-unicast unsuppress-map RMAP

  Configuration path: protocols nbgp 65001 neighbor 10.0.0.1 address-family ipv4-unicast unsuppress-map [RMAP] is not valid
  Set failed
  1. Delete deprecated option "enforce-first-as" T2828
set protocols bgp 65001 parameters enforce-first-as
  1. Unable to set description for neighbor
vyos@r4-roll# set protocols nbgp 65001 neighbor 10.0.0.2 description foo

  Configuration path: protocols nbgp 65001 neighbor 10.0.0.2 description [foo] is not valid
  Set failed

[edit]

PR https://github.com/vyos/vyos-1x/pull/584

Fixed XML for

set protocols nbgp 65001 neighbor 10.0.0.1 address-family ipv4-unicast unsuppress-map RMAP
set protocols nbgp 65001 neighbor 10.0.0.2 description foo

We can also delete full protocol nbgp.

Bugs

  1. Not all interfaces can be used as "update-source"

Missed "vti | dum | lo" etc.
https://github.com/vyos/vyos-1x/blob/current/interface-definitions/protocols-bgp.xml.in#L639

  1. Missed capability dynamic. Questionable. T3037
vyos@r4-roll# set protocols nbgp 100 neighbor aa:bb:cc:dd:ee::1 address-family ipv6-unicast capability dynamic

  Configuration path: protocols nbgp 100 neighbor aa:bb:cc:dd:ee::1 address-family ipv6-unicast capability [dynamic] is not valid
  Set failed

Unable to set update source "lo" interface
For afi6 should be "redistribute ospfv3" instead "ospf"

erkin set Issue type to Internal change (not visible to end users).Mon, Aug 30, 6:32 AM
erkin removed a subscriber: Active contributors.