Page MenuHomeVyOS Platform

Make VLAN interfaces subclasses of Interface class
Closed, InvalidPublic

Description

Make vif, vif-s and vif-c subclasses of ifconfig.Interfaces so we can use the parent classes add_addr/del_addr functions on them.

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Behavior change
Issue type
Internal change (not visible to end users)

Event Timeline

jjakob triaged this task as Normal priority.May 2 2020, 12:18 PM
jjakob created this task.
jjakob created this object in space S1 VyOS Public.

We must be able to call klass('eth0.1.2', create=False).add_addr to add an address on the vif-c and also klass('eth0.1', create=False).add_addrto add an address on the vif-s. I'm adding functions on Interfaces class to purge/restore addresses which will be used when adding/removing bridge/bond members, T2367.

This isn't as important as I thought initially as the interface scripts verify function will prevent adding interfaces with addresses to a bridge or bond - thus a simple 'ip addr flush dev x' will suffice to flush the remaining (should be just the fe80 link-local), as there should be no dhclients running.

jjakob moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.
erkin set Issue type to Internal change (not visible to end users).Aug 30 2021, 6:23 AM
erkin removed a subscriber: Active contributors.