Page MenuHomeVyOS Platform
Create Task
Maniphest T2667

get_config_dict: Use utility function for non-empty path argument
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

Currently, get_config_dict provides the sub-config at 'path', by passing the path argument to show_config. This results in

  1. the behaviour cited in T2662 through the interaction of the backend and configtree
  2. an additional dependency on, and call to, the vyatta backend
  3. ceding control of the result to the backend

As an alternative, it is suggested to add a utility function 'get_sub_dict', and apply that to the full config_dict obtained from show_config, for a non-empty path.

Details

Difficulty level
Normal (likely a few hours)
Version
vyos-1.3
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Related Objects
Search...

Event Timeline

jestabro changed the task status from Open to Needs testing.Jul 1 2020, 6:24 PM
jestabro triaged this task as Normal priority.
jestabro created this task.
jestabro created this object in space S1 VyOS Public.
jestabro added a comment.Jul 1 2020, 6:37 PM

https://github.com/vyos/vyos-1x/pull/486

jestabro updated the task description. (Show Details)Jul 1 2020, 6:39 PM
jestabro moved this task from Need Triage to In Progress on the VyOS 1.3 Equuleus board.
jestabro added a parent task: T2662: get_config_dict includes node name as key only for tag and leaf nodes.Jul 1 2020, 6:55 PM
jestabro added a subtask: T2668: get_config_dict: add get_first_key arg to utility function get_sub_dict.Jul 1 2020, 7:22 PM
jestabro closed this task as Resolved.Jul 1 2020, 11:45 PM
jestabro moved this task from In Progress to Finished on the VyOS 1.3 Equuleus board.
jestabro mentioned this in T2662: get_config_dict includes node name as key only for tag and leaf nodes.
jestabro closed subtask T2668: get_config_dict: add get_first_key arg to utility function get_sub_dict as Resolved.Jul 2 2020, 1:47 AM
pasik added a subscriber: pasik.Jul 2 2020, 12:26 PM
jestabro mentioned this in T2670: Remove dependency on show_config from get_config_dict.Jul 2 2020, 1:21 PM
jestabro added a subtask: T2670: Remove dependency on show_config from get_config_dict.
jestabro closed subtask T2670: Remove dependency on show_config from get_config_dict as Resolved.Jul 3 2020, 1:12 PM
jestabro updated the task description. (Show Details)
erkin set Issue type to Internal change (not visible to end users).Aug 29 2021, 1:59 PM
erkin removed a subscriber: Active contributors.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 7:13 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.