Page MenuHomeVyOS Platform

DHCP-server overlapping ranges.
Closed, ResolvedPublicBUG

Description

When we use overlapping ranges in DHCP-server configuration, it commit without errors, but DHCP-server not start.
To reproduce:

set service dhcp-server shared-network-name NET01 authoritative
set service dhcp-server shared-network-name NET01 subnet 10.0.0.0/24 default-router '10.0.0.1'
set service dhcp-server shared-network-name NET01 subnet 10.0.0.0/24 lease '86400'
set service dhcp-server shared-network-name NET01 subnet 10.0.0.0/24 range RNG01 start '10.0.0.60'
set service dhcp-server shared-network-name NET01 subnet 10.0.0.0/24 range RNG01 stop '10.0.0.70'
set service dhcp-server shared-network-name NET01 subnet 10.0.0.0/24 range RNG02 start '10.0.0.55'
set service dhcp-server shared-network-name NET01 subnet 10.0.0.0/24 range RNG02 stop '10.0.0.65'
commit

Logs:

Jul 02 08:42:25 r-roll systemd[1]: Starting ISC DHCP IPv4 server...
Jul 02 08:42:25 r-roll dhcpd[3307]: /run/dhcp-server/dhcpd.conf line 25: lease 10.0.0.60 is declared twice!
Jul 02 08:42:25 r-roll dhcpd[3307]:         range 10.0.0.55 10.0.0.65;
Jul 02 08:42:25 r-roll dhcpd[3307]:                                   ^
Jul 02 08:42:25 r-roll dhcpd[3307]: /run/dhcp-server/dhcpd.conf line 25: lease 10.0.0.61 is declared twice!
Jul 02 08:42:25 r-roll dhcpd[3307]:         range 10.0.0.55 10.0.0.65;
Jul 02 08:42:25 r-roll dhcpd[3307]:                                   ^
Jul 02 08:42:25 r-roll dhcpd[3307]: /run/dhcp-server/dhcpd.conf line 25: lease 10.0.0.62 is declared twice!
Jul 02 08:42:25 r-roll dhcpd[3307]:         range 10.0.0.55 10.0.0.65;
Jul 02 08:42:25 r-roll dhcpd[3307]:                                   ^
Jul 02 08:42:25 r-roll dhcpd[3307]: /run/dhcp-server/dhcpd.conf line 25: lease 10.0.0.63 is declared twice!
Jul 02 08:42:25 r-roll dhcpd[3307]:         range 10.0.0.55 10.0.0.65;
Jul 02 08:42:25 r-roll dhcpd[3307]:                                   ^
Jul 02 08:42:25 r-roll dhcpd[3307]: /run/dhcp-server/dhcpd.conf line 25: lease 10.0.0.64 is declared twice!
Jul 02 08:42:25 r-roll dhcpd[3307]:         range 10.0.0.55 10.0.0.65;
Jul 02 08:42:25 r-roll dhcpd[3307]:                                   ^
Jul 02 08:42:25 r-roll dhcpd[3307]: /run/dhcp-server/dhcpd.conf line 25: lease 10.0.0.65 is declared twice!
Jul 02 08:42:25 r-roll dhcpd[3307]:         range 10.0.0.55 10.0.0.65;
Jul 02 08:42:25 r-roll dhcpd[3307]:                                   ^
Jul 02 08:42:25 r-roll dhcpd[3307]: Configuration file errors encountered -- exiting
Jul 02 08:42:25 r-roll dhcpd[3307]: 
Jul 02 08:42:25 r-roll dhcpd[3307]: exiting.
Jul 02 08:42:25 r-roll systemd[1]: isc-dhcp-server.service: Control process exited, code=exited, status=1/FAILURE
Jul 02 08:42:25 r-roll systemd[1]: isc-dhcp-server.service: Failed with result 'exit-code'.
Jul 02 08:42:25 r-roll systemd[1]: Failed to start ISC DHCP IPv4 server.

DHCP config:

# Shared network configration(s)
shared-network NET01 {
    authoritative;
    subnet 10.0.0.0 netmask 255.255.255.0 {
        option routers 10.0.0.1;
        default-lease-time 86400;
        max-lease-time 86400;
        range 10.0.0.60 10.0.0.70;
        range 10.0.0.55 10.0.0.65;
    }
    on commit {
        set shared-networkname = "NET01";

    }
}

Additional checks are needed.

Details

Difficulty level
Easy (less than an hour)
Version
VyOS 1.3-rolling-202007020117
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

c-po claimed this task.
c-po triaged this task as Normal priority.
c-po changed Difficulty level from Unknown (require assessment) to Easy (less than an hour).
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.
erkin set Issue type to Bug (incorrect behavior).Aug 29 2021, 1:58 PM
erkin removed a subscriber: Active contributors.