Page MenuHomeVyOS Platform

Remove dependency on show_config from get_config_dict
Closed, ResolvedPublic

Description

On initialization, Config calls the backend showConfig (with --show-show-defaults) to obtain the active and session config state; get_config_dict makes a second call, as it was dependent on the path-relative showConfig(path, ...).

  1. The path-relative call is no longer required, due to T2667
  2. The nature of default values has been rationalized by T2588

Consequently, the additional call to showConfig can be removed from get_config_dict, relying instead on the data provided at initialization. This will improve performance, as each call to showConfig is on the order of ~50 ms, and moreover, allow a cleaner generalization of Config for off-line testing and the vyos-configd daemon.

Details

Difficulty level
Unknown (require assessment)
Version
vyos-1.3
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible

Event Timeline

jestabro closed this task as Resolved.Jul 3 2020, 1:12 PM
jestabro moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.