Page MenuHomeVyOS Platform
Create Task
Maniphest T2691

Upgrade from 1.2.5 to 1.3-rolling-202007040117 results in broken config due to case mismatch
Closed, ResolvedPublicBUG
Actions

Description

When upgrading from 1.2.5 to 1.3-rolling-202007040117, the configuration does not load correctly on first boot. When loaded manually, the failing section is:

...
ssh {
    disable-password-authentication
    loglevel info
}
...

The 1.3 syntax appears to be loglevel INFO.

The upgrade should tolerate insignificant case differences like this.

Details

Difficulty level
Unknown (require assessment)
Version
1.3-rolling-202007040117
Why the issue appeared?
Design mistake
Is it a breaking change?
Config syntax change (migratable)
Issue type
Bug (incorrect behavior)

Event Timeline

paulgear created this task.Jul 7 2020, 9:13 AM
paulgear added a comment.Jul 7 2020, 9:45 AM

Adding screenshots showing the error and the fix.

Screenshot from 2020-07-07 19-42-57.png (420×736 px, 9 KB)

Screenshot from 2020-07-07 19-43-42.png (423×608 px, 6 KB)

c-po claimed this task.Jul 7 2020, 4:05 PM
c-po added a comment.Jul 7 2020, 4:25 PM

The reason this is failing is VyOS 1.2 lacks proper input validation on the loglevel nodes.

https://github.com/vyos/vyos-1x/blob/crux/interface-definitions/ssh.xml#L123-L147 - in fact every string is supported. I will write a validator sanitizing the inputs

c-po closed this task as Resolved.Jul 7 2020, 5:10 PM
c-po triaged this task as Unbreak Now! priority.
c-po changed Why the issue appeared? from Will be filled on close to Design mistake.
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Aug 3 2020, 2:15 PM
erkin set Issue type to Bug (incorrect behavior).Aug 29 2021, 1:54 PM
erkin removed a subscriber: Active contributors.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 7:13 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.