Redirecting traffic from PPPoE interface to IFB fails
Open, Requires assessmentPublicBUG
Actions

Description

On Equuleus, when redirecting traffic from a PPPoE interface to an Intermediate Functional Block interface, the redirected PPPoE interface is completely deleted from the configuration when VyOS boots.

vyos@vyos# set interfaces input ifb0
[edit]
vyos@vyos# commit
[edit]
vyos@vyos# set interfaces pppoe pppoe0 redirect ifb0
[edit]
vyos@vyos# commit
[edit]
vyos@vyos# run show configuration comm | grep ifb0
set interfaces input ifb0
set interfaces pppoe pppoe0 redirect 'ifb0'
[edit]
vyos@vyos# run show configuration comm | grep pppoe
set interfaces pppoe pppoe0 authentication password 'MYPASSWORD'
set interfaces pppoe pppoe0 authentication user 'MYUSER'
set interfaces pppoe pppoe0 default-route 'force'
set interfaces pppoe pppoe0 mtu '1492'
set interfaces pppoe pppoe0 redirect 'ifb0'
set interfaces pppoe pppoe0 source-interface 'eth2.35'
set interfaces pppoe pppoe0 traffic-policy out 'OUT2'
[edit]
vyos@vyos# save
Saving configuration to '/config/config.boot'...
Done
[edit]
vyos@vyos# exit
exit
vyos@vyos:~$ reboot
Are you sure you want to reboot this system? [y/N] y

After reboot:

Welcome to VyOS - vyos ttyS0

vyos login: vyos
Password: 
Linux vyos 4.19.128-amd64-vyos #1 SMP Sun Jun 14 16:27:56 UTC 2020 x86_64

The programs included with the Debian GNU/Linux system are free software;
the exact distribution terms for each program are described in the
individual files in /usr/share/doc/*/copyright.

Debian GNU/Linux comes with ABSOLUTELY NO WARRANTY, to the extent
permitted by applicable law.
vyos@vyos:~$ show configuration comm | grep pppoe
vyos@vyos:~$ show configuration comm | grep ifb0
set interfaces input ifb0
vyos@vyos:~$

On Crux, when redirecting traffic from a PPPoE interface to an Intermediate Functional Block interface, you may get the following message when committing:

vyos@pppoe-client# set interfaces input ifb0
[edit]
vyos@pppoe-client# commit
[edit]
vyos@pppoe-client# set interfaces ethernet eth2 vif 35 pppoe 0 redirect ifb0
[edit]
vyos@pppoe-client# commit
[ interfaces ethernet eth2 vif 35 pppoe 0 redirect ifb0 ]
Exiting subroutine via next at /opt/vyatta/sbin/vyatta-qos.pl line 315.

Then the configuration looks ok, but there must be something wrong, because when an outbound shaping policy is applied to ifb0, shaping does not take place.

Details

Difficulty level: Unknown (require assessment)
Version: 1.2.x ; 1.3
Why the issue appeared?: Will be filled on close
Is it a breaking change?: Unspecified (possibly destroys the router)
Issue type: Bug (incorrect behavior)

Event Timeline

s.lorente created this task.Jul 12 2020, 4:33 PM

s.lorente updated the task description. (Show Details)Jul 12 2020, 6:17 PM

pasik added a subscriber: pasik.Jul 13 2020, 5:25 PM

mpueschel added a subscriber: mpueschel.Jul 20 2020, 3:44 PM

https://forum.vyos.io/t/limit-download-and-upload-on-wan-for-every-vlan/5608/51

I think I know what's happening here.

I don't have pppoe to test, but from my testbed, I think I know what's happening. The pppoe interface doesn't exist until it comes up. On my system, I can't even commit initially because my pppoe interface isn't coming up.

So on reboot, it's some kind of ordering issue. If you have working pppoe, that means you can commit and it works until reboot, but it won't work afterwards.

The interface isn't up yet, so it can't apply the qos

Yes that's correct. And there is already some sort of check implemented for the node traffic-policy, so it does not fail when the pppoe interface does not exist yet. It just shows a warning: https://github.com/vyos/vyatta-cfg-qos/blob/bbf2b2f06b7a0f883f7134df5e2b3e089015738e/scripts/vyatta-qos.pl#L198

Something similar would probably be needed for the redirect node. But that's only based on my very limited understanding of the code, so take it with a grain of salt

fegauthier added a subscriber: fegauthier.Oct 2 2020, 11:50 AM

francescocarzaniga added a subscriber: francescocarzaniga.Jan 31 2021, 10:43 PM

cprosser added a subscriber: cprosser.Mar 22 2021, 12:54 AM

erkin set Issue type to Bug (incorrect behavior).Aug 29 2021, 1:50 PM

erkin removed a subscriber: Active contributors.

syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Nov 6 2021, 11:24 AM

To reproduce:

set interfaces ethernet eth2 vif 35
set interfaces pppoe pppoe0 authentication password 'MYPASSWORD'
set interfaces pppoe pppoe0 authentication user 'MYUSER'
set interfaces pppoe pppoe0 default-route 'force'
set interfaces pppoe pppoe0 mtu '1492'
set interfaces pppoe pppoe0 redirect 'ifb0'
set interfaces pppoe pppoe0 source-interface 'eth2.35'
set interfaces pppoe pppoe0 traffic-policy out 'OUT2'
set interfaces input ifb0

Commit:

vyos@r11-roll# commit
[ interfaces pppoe pppoe0 redirect ifb0 ]
Cannot find device "pppoe0"
tc qdisc ingress failed at /opt/vyatta/sbin/vyatta-qos.pl line 334.

[[interfaces pppoe pppoe0]] failed
Commit failed
[edit]
vyos@r11-roll#

Manual adding:

vyos@r11-roll# /sbin/tc qdisc add dev pppoe0 handle ffff: ingress
Cannot find device "pppoe0"
[edit]
vyos@r11-roll#

Redirecting traffic from PPPoE interface to IFB failsOpen, Requires assessmentPublicBUGActions

Description

Details

Event Timeline

Redirecting traffic from PPPoE interface to IFB fails
Open, Requires assessmentPublicBUG
Actions