Page MenuHomeVyOS Platform

"show flow-accounting" should not display script's "usage" help
Closed, ResolvedPublicBUG

Description

Right now if you give show flow-accounting a bad argument, it will display something like this:

vyos@vyos-test-2# run show flow-accounting interface eth0 port 33r
usage: flow_accounting_op.py [-h] --action {show,clear,restart}
                             [--filter [{interface,host,ports,top} [{interface,host,ports,top} ...]]]
                             [--interface INTERFACE] [--host HOST]
                             [--ports PORTS] [--top TOP]
flow_accounting_op.py: error: argument --ports: Invalid ports: 33r

Most people will never run the script by hand though, so information how to use it by hand is useless for them. None of our scripts do that, they just display the actual error and exit.

This one shouldn't be different.

Details

Difficulty level
Easy (less than an hour)
Version
1.3-rolling-202007152012
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Revisions and Commits

Event Timeline

GitHub <noreply@github.com> closed this task as Resolved by committing Restricted Diffusion Commit.Jul 19 2020, 11:55 AM
GitHub <noreply@github.com> added a commit: Restricted Diffusion Commit.
erkin set Issue type to Bug (incorrect behavior).Aug 29 2021, 1:49 PM
erkin removed a subscriber: Active contributors.