Page MenuHomeVyOS Platform

Add smoketest to ensure script consistency with config daemon
Closed, ResolvedPublic

Description

A smoketest using the inspect module to ensure that those scripts on the the config daemon include list conform to the coding guidelines, a requirement for running under the daemon. This is a sanity check to catch any regressions in said conformity.

Secondly, there is a on occasion a legitimate need to run as a standalone process; namely, in the case where the script needs to modify the session config (for example, system-login.py); those scripts are not added to the include list, and the smoketest will confirm that no such has been accidentally included.

The smoketest checks all included script in ~1s.

Note that this branch will need to be added after those in T2582.

https://github.com/jestabro/vyos-smoketest/tree/vyos-configd

Details

Difficulty level
Unknown (require assessment)
Version
vyos-1.3
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Event Timeline

jestabro changed the task status from Open to Needs testing.Aug 18 2020, 3:45 PM
jestabro triaged this task as Normal priority.
jestabro created this task.
jestabro created this object in space S1 VyOS Public.
jestabro moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.
erkin set Issue type to Internal change (not visible to end users).Aug 29 2021, 1:22 PM
erkin removed a subscriber: Active contributors.