Page MenuHomeVyOS Platform

Migrate PPPoE server to get_config_dict() do reduce boilerplate code
Closed, ResolvedPublicFEATURE REQUEST

Description

Instead of writing config.exists() and return we should utilize the new get_config_dict() functionality.

This would also be a good idea to move common parts shared across pppoe, ipoe, sstp server to a Jinja2 include file. Thus the generated config is sourced from a common template.

Details

Difficulty level
Hard (possibly days)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Internal change (not visible to end users)

Event Timeline

c-po changed the task status from Open to In progress.Sep 29 2020, 6:42 PM
c-po claimed this task.
c-po triaged this task as Low priority.
c-po created this task.
c-po changed Difficulty level from Unknown (require assessment) to Hard (possibly days).
erkin set Issue type to Internal change (not visible to end users).Aug 29 2021, 12:49 PM