Page MenuHomeVyOS Platform
Create Task
Maniphest T3010

ttl option of gre-bridge
Closed, ResolvedPublicBUG
Actions

Description

Hello,
Current vyos disabled the ttl option for gre-bridge tunnel, but it is supported by ip link.
I have added it on my local vyos, and it works fine.

Please consider add this to further distribution.

Thanks.

Details

Difficulty level
Easy (less than an hour)
Version
1.3
Why the issue appeared?
Design mistake
Is it a breaking change?
Perfectly compatible
Issue type
Feature (new functionality)

Event Timeline

jingyun created this task.Oct 23 2020, 5:41 AM
pasik added a subscriber: pasik.Oct 23 2020, 8:16 AM
c-po added a subscriber: c-po.Oct 24 2020, 3:23 PM

Hi @jingyun, can you share how you added it to your local installation?

Could you possible send us a PullRequest (https://docs.vyos.io/en/latest/contributing/development.html#submit-a-patch)?

jingyun added a comment.Oct 24 2020, 3:40 PM

hello,
Just modify the line 182 of file /usr/lib/python3/dist-packages/vyos/ifconfig/tunnel.py
from

options = ['local', 'remote', ]

to

options = ['local', 'remote', 'ttl', ]

Then reboot the VyOS, it will load the modified python file, and ttl could be set afterwards.

As I'm not familiar with VyOS development, and the patch procedure, can you kindly do this?

Thank you.

jack9603301 added a subscriber: jack9603301.Oct 24 2020, 3:58 PM

Have you ever tested it?

jingyun added a comment.Oct 24 2020, 4:06 PM

Hello,
This is working as "ip link add tun0 type gretap local x.x.x.x remote y.y.y.y ttl z" in linux.

I have tested it in my server, and it works as expected.

Thank you.

jack9603301 added a comment.Oct 24 2020, 5:33 PM

/usr/lib/python3/dist-packages/vyos/ifconfig/ tunnel.py The corresponding file is in https://github.com/vyos/vyos-1x/blob/current/python/vyos/ifconfig/tunnel.py

Please fork and modify it in the local version library, and then recompile ISO for testing. If successful, please submit PR, @c-po has told you how to participate in the contribution

c-po closed this task as Resolved.Oct 24 2020, 6:49 PM
c-po claimed this task.
c-po triaged this task as Normal priority.
c-po changed Why the issue appeared? from Will be filled on close to Design mistake.
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Nov 23 2020, 4:01 PM
erkin set Issue type to Feature (new functionality).Aug 29 2021, 12:28 PM
erkin removed a subscriber: Active contributors.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 12:27 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.