Page MenuHomeVyOS Platform

Let VLAN aware bridge approach the behavior of professional equipment
Closed, ResolvedPublicFEATURE REQUEST

Description

The current implementation of VLAN aware bridge is not perfect, and there are various problems in the implementation. Now, let's modify the implementation of VLAN bridge to make it close to professional equipment.

For a discussion of the VLAN aware bridge consensus, see T1354

Implement the following design features

  1. Disable vif 1 configuration
  2. When the VLAN aware bridge is enabled, the parent interface is always VLAN 1
  3. When native-vlan is not configured, the default behavior of the device is native-vlan 1
  4. The VLAN ids forwarded by the bridge are determined by vif
  5. It has an enable-vlan node to enable VLAN awareness
  6. VLAN configuration is allowed only when VLAN aware bridge is activated

The implementation needs to be divided into the following stages:

  • Modify the current implementation to meet the characteristics discussed in the new consensus
  • This change requires modification of the document

Details

Difficulty level
Easy (less than an hour)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible

Event Timeline

jack9603301 changed the task status from Open to Confirmed.Dec 19 2020, 1:06 PM
jack9603301 claimed this task.
jack9603301 triaged this task as Low priority.
jack9603301 created this task.
jack9603301 changed Why the issue appeared? from Will be filled on close to Implementation mistake.Dec 19 2020, 1:27 PM
jack9603301 changed the task status from Confirmed to In progress.Dec 19 2020, 2:38 PM
jack9603301 renamed this task from When the bridge is a VLAN-aware bridge, the parent interface of the bridge can be set with an address to When setting a VLAN-aware bridge, the VLAN ID of the parent interface is always 1.Dec 22 2020, 5:36 AM
jack9603301 updated the task description. (Show Details)

VLAN-aware bridge is a special use case. We should design additional special rules for VLAN-aware bridges. This rule should be consistent with the behavior of other routers and switch manufacturers, combined with https://phabricator.vyos.net/ According to T1354, can the following changes be considered:

  1. Maybe we can set set interfaces bridge br1 vlan-aware to activate the VLAN aware bridge function
  2. Set the parent interface and child members of the bridge. When the VLAN-aware bridge is turned on, native-vlan 1 is the default value, unless the native-vlan is manually modified, which means that when VLAN-aware is enabled by default, all Untagged packets are all members of VLAN 1
jack9603301 renamed this task from When setting a VLAN-aware bridge, the VLAN ID of the parent interface is always 1 to Let VLAN aware bridge approach the behavior of professional equipment.Sat, Jan 9, 5:28 AM
jack9603301 raised the priority of this task from Low to Normal.
jack9603301 updated the task description. (Show Details)
jack9603301 changed the subtype of this task from "Bug" to "Feature Request".
jack9603301 changed the subtype of this task from "Feature Request" to "Bug".Sat, Jan 9, 6:00 AM
jack9603301 changed Why the issue appeared? from Implementation mistake to Will be filled on close.
jack9603301 changed the subtype of this task from "Bug" to "Feature Request".

@runar @c-po A new PR has been created and can be reviewed

jack9603301 changed the task status from In progress to Needs testing.Sat, Jan 16, 9:56 AM
jack9603301 moved this task from In Progress to Finished on the VyOS 1.3 Equuleus board.
jack9603301 moved this task from Finished to In Progress on the VyOS 1.3 Equuleus board.
jack9603301 moved this task from In Progress to Finished on the VyOS 1.3 Equuleus board.