Page MenuHomeVyOS Platform
Create Task
Maniphest T3203

BGP unnumbered - commit fails when route-reflector-client is set
Resolved (N/A)Public
Actions

Description

When BGP unnumbered (extended-nexthop) and route-reflector-client are set on a neighbor, the commit fails with the following error:

[ protocols bgp 654435 neighbor eth0 address-family ipv4-unicast route-reflector-client ]
sh: line 0: [: 654435: unary operator expected

[ protocols bgp 654435 neighbor eth0 address-family ipv6-unicast route-reflector-client ]
sh: line 0: [: 654435: unary operator expected

Example configuration:

set protocols bgp 654435 neighbor eth0 address-family ipv4-unicast nexthop-self force
set protocols bgp 654435 neighbor eth0 address-family ipv4-unicast route-reflector-client
set protocols bgp 654435 neighbor eth0 address-family ipv6-unicast nexthop-self force
set protocols bgp 654435 neighbor eth0 address-family ipv6-unicast route-reflector-client
set protocols bgp 654435 neighbor eth0 address-family ipv6-unicast soft-reconfiguration inbound
set protocols bgp 654435 neighbor eth0 capability extended-nexthop
set protocols bgp 654435 neighbor eth0 interface remote-as '654435'
set protocols bgp 654435 neighbor eth0 interface v6only

Version:

vyos@vyos# run show version 

Version:          VyOS 1.3-rolling-202101071430
Release Train:    equuleus

Built by:         [email protected]
Built on:         Thu 07 Jan 2021 14:30 UTC
Build UUID:       710ade27-8981-49da-ac27-47acc9b4f413
Build Commit ID:  432f3f96927a54

Details

Difficulty level
Unknown (require assessment)
Version
1.3-rolling-202101071430
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Unspecified (please specify)

Related Objects
Search...

Event Timeline

tom.siewert created this task.Jan 10 2021, 12:46 PM
tom.siewert created this object in space S1 VyOS Public.
tom.siewert updated the task description. (Show Details)Jan 10 2021, 3:04 PM
pasik added a subscriber: pasik.Jan 10 2021, 6:43 PM
Viacheslav added a subscriber: Viacheslav.EditedJan 11 2021, 11:34 AM

1.2 crux the same behavior

The problem probably here
https://github.com/vyos/vyatta-cfg-quagga/blob/equuleus/templates/protocols/bgp/node.tag/neighbor/node.tag/address-family/ipv4-unicast/route-reflector-client/node.def

It expects "remote-as" from a different place.

Works without errors

set protocols bgp 654435 neighbor 10.0.0.2 remote-as '654435'
set protocols bgp 654435 neighbor 10.0.0.2 address-family ipv4-unicast route-reflector-client

It only an informational bug, so configuration accepted

set protocols bgp 654435 neighbor eth1 interface remote-as 654435
set protocols bgp 654435 neighbor eth1 address-family ipv4-unicast route-reflector-client

vyos@r5-roll# commit
[ protocols bgp 654435 neighbor eth1 address-family ipv4-unicast route-reflector-client ]
sh: line 0: [: 654435: unary operator expected

[edit]
vyos@r5-roll#
Viacheslav added a comment.Jan 11 2021, 2:29 PM

Needs to add that expression with the right logic.

$VAR(../../../../@) != $VAR(../../../interface/remote-as/@)
Viacheslav added a parent task: T2174: Rewrite protocol BGP to new XML/Python style.Jan 15 2021, 7:31 PM
c-po added a subscriber: c-po.Apr 17 2021, 7:01 PM

Can you please re-test this with VyOS 1.4?

dmbaturin added a project: test.Jul 29 2021, 8:56 AM
dmbaturin added a subscriber: dmbaturin.

Still reproducible in 1.3.0-rc5.

syncer edited projects, added VyOS 1.3 Equuleus (1.3.0-epa1); removed test, VyOS 1.3 Equuleus.Sep 5 2021, 7:06 AM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus (1.3.0-epa1).Nov 1 2021, 10:09 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.3); removed VyOS 1.3 Equuleus (1.3.0).Aug 29 2022, 7:04 AM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.3).Jul 12 2023, 9:40 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.5); removed VyOS 1.3 Equuleus (1.3.4).Aug 25 2023, 9:29 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.6); removed VyOS 1.3 Equuleus (1.3.5).Dec 17 2023, 11:37 PM
dmbaturin closed this task as Resolved N/A.Jan 9 2024, 8:26 PM

No longer reproducible in 1.5

dmbaturin edited projects, added VyOS 1.4 Sagitta; removed VyOS 1.3 Equuleus (1.3.6).Jan 9 2024, 8:26 PM
dmbaturin set Issue type to Unspecified (please specify).