Page MenuHomeVyOS Platform

Save FRR configuration on each commit
Needs testing, Requires assessmentPublic

Description

Since we are using watchfrr, there can be a situation when watchfrr restarts a daemon. Since we only build FRR configuration in memory, that daemon will lose all its configuration.

In the old node.def's we had a call to vtysh -c 'save' at the end of each protocol node. That bit was lost in migration to XML and Python. It should be easy to restore though.

We only need to move FRR configuration to /run so that config files do not persist between reboots, and already removed configuration cannot rise from the dead. Since FRR has a command line option for config file path, this should be simple enough..

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible

Related Objects

StatusSubtypeAssignedTask
Needs testingNone
Needs testingBUGzsdc

Event Timeline

dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.

Chown for saved configuration file should be frr:frr

root@r5-roll:/home/vyos# ls -la /run/frr/ | awk /static/
-rw-r--r--  1 root vyattacfg  197 Apr  1 08:42 staticd.conf
-rw-r--r--  1 frr  frr          4 Apr  1 08:42 staticd.pid
srwxrwx---  1 frr  frrvty       0 Apr  1 08:42 staticd.vty
root@r5-roll:/home/vyos#
Viacheslav changed the task status from Open to Needs testing.Fri, Apr 2, 9:00 PM
This comment was removed by Viacheslav.