Page MenuHomeVyOS Platform
Create Task
Maniphest T3222

Typo in BGP dampening description
Closed, ResolvedPublicBUG
Actions

Description

There is a few mistakes in BGP dampening description

dampening.PNG (675×990 px, 43 KB)

Details

Difficulty level
Easy (less than an hour)
Version
1.4-rolling-202101110217
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Cosmetic issue (typos etc.)

Related Objects
Search...

Event Timeline

craterman created this task.Jan 16 2021, 9:16 AM
Viacheslav added a parent task: T2174: Rewrite protocol BGP to new XML/Python style.Jan 16 2021, 10:52 AM
Viacheslav added a subscriber: Viacheslav.Jan 16 2021, 11:23 AM

PR https://github.com/vyos/vyos-1x/pull/685

Viacheslav changed the task status from Open to Needs testing.Jan 16 2021, 3:03 PM
Viacheslav claimed this task.
c-po added a subscriber: c-po.Jan 17 2021, 8:12 AM

Thank you @craterman for starting testing of our new BGP implementation.

pasik added a subscriber: pasik.Jan 17 2021, 10:37 AM
Viacheslav added a comment.Jan 17 2021, 5:19 PM

Fixed in VyOS 1.4-rolling-202101171022

c-po closed this task as Resolved.Jan 17 2021, 5:42 PM
craterman added a comment.Jan 19 2021, 5:30 PM

Looks good. But maybe it is reasonable to change argument start-suppress-time to start-suppress because it is not a time, but penalty points

c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Mar 18 2021, 4:27 PM
c-po moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.May 24 2021, 7:41 PM
SrividyaA renamed this task from BGP dampening description to Typo in BGP dampening description.Aug 30 2021, 5:22 PM
SrividyaA set Issue type to Cosmetic issue (typos etc.).
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 12:26 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.