When adding a BGP neighbor with an address on a local interface, running commit throws a vyos.frr.CommitError: Configuration FRR failed while committing code: ''
While this is of course not a valid BGP neighbor configuration, the error message is less than helpful.
Steps to reproduce:
set interfaces loopback lo address 192.0.2.1/32
set protocols bgp 65530 neighbor 192.0.2.1 remote-as 65531
commit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| In progress | FEATURE REQUEST | None | T3355 Remove all remaining legacy Vyatta code | ||
| Resolved | c-po | T2175 Rewriting all FRR processes allow for reloading and to XML/Python style | |||
| Resolved | FEATURE REQUEST | c-po | T2174 Rewrite protocol BGP to new XML/Python style | ||
| Resolved | BUG | runar | T3227 Latest releases don't work with RPKI (crash) | ||
| Resolved | BUG | Viacheslav | T3225 Adding a BGP neighbor with an address on a local interface throws a vyos.frr.CommitError: Configuration FRR failed while committing code: '' |
PR https://github.com/vyos/vyos-1x/pull/748
Add checks for neighbor "is_addr_assigned"
Fail
set protocols bgp 64501 neighbor 203.0.113.1 remote-as 65001
set protocols bgp 64501 neighbor 203.0.113.1 peer-group FOO
set protocols bgp 64501 peer-group FOO
Traceback (most recent call last):
File "/usr/libexec/vyos/conf_mode/protocols_bgp.py", line 207, in <module>
verify(c)
File "/usr/libexec/vyos/conf_mode/protocols_bgp.py", line 112, in verify
if is_addr_assigned(peer):
File "/usr/lib/python3/dist-packages/vyos/validate.py", line 108, in is_addr_assigned
tmp = is_intf_addr_assigned(intf, addr)
File "/usr/lib/python3/dist-packages/vyos/validate.py", line 50, in is_intf_addr_assigned
return _is_intf_addr_assigned(intf, addr)
File "/usr/lib/python3/dist-packages/vyos/validate.py", line 84, in _is_intf_addr_assigned
if not _are_same_ip(address, ip_addr):
File "/usr/lib/python3/dist-packages/vyos/validate.py", line 44, in _are_same_ip
return inet_pton(f_one, one) == inet_pton(f_one, two)
OSError: illegal IP address string passed to inet_ptonIt seems it's trying to check no only neighbor IP address and also and peer-group name "is_addr_assigned".
The neighbor can contain a string
set protocols bgp 64501 neighbor eth1
set protocols bgp 64501 neighbor eth1 remote-as 65001
commit
Traceback (most recent call last):
File "/usr/libexec/vyos/conf_mode/protocols_bgp.py", line 212, in <module>
verify(c)
File "/usr/libexec/vyos/conf_mode/protocols_bgp.py", line 121, in verify
if is_addr_assigned(peer):
File "/usr/lib/python3/dist-packages/vyos/validate.py", line 108, in is_addr_assigned
tmp = is_intf_addr_assigned(intf, addr)
File "/usr/lib/python3/dist-packages/vyos/validate.py", line 50, in is_intf_addr_assigned
return _is_intf_addr_assigned(intf, addr)
File "/usr/lib/python3/dist-packages/vyos/validate.py", line 84, in _is_intf_addr_assigned
if not _are_same_ip(address, ip_addr):
File "/usr/lib/python3/dist-packages/vyos/validate.py", line 44, in _are_same_ip
return inet_pton(f_one, one) == inet_pton(f_one, two)
OSError: illegal IP address string passed to inet_ptonPR https://github.com/vyos/vyos-1x/pull/751
set interfaces ethernet eth1 address 192.0.2.1/24 set protocols bgp 64501 neighbor eth1 interface remote-as '64501' set protocols bgp 64501 neighbor 192.0.2.1 remote-as 65002 vyos@r-roll01# commit [ protocols bgp 64501 ] Can't configure local address as neighbor "192.0.2.1" [[protocols bgp 64501]] failed Commit failed [edit] vyos@r-roll01#