Page MenuHomeVyOS Platform

merge/load fail silently if unable to resolve host
Closed, ResolvedPublicBUG

Description

The config mode commands 'merge' and 'load' will fail silently if passed a remote config file location whose hostname is unresolved.

Details

Difficulty level
Easy (less than an hour)
Version
vyos-1.4
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible

Event Timeline

jestabro triaged this task as Normal priority.Feb 3 2021, 7:56 PM
jestabro created this task.
jestabro created this object in space S1 VyOS Public.

Assuming T3356 can be backported to equuleus, this fix will not be needed.

erkin added a subscriber: erkin.

I'll give backporting a try. It should be doable as long as Paramiko is in our reach. If not, I'll see if I can cobble together something to check for hostname resolution failure.

Thanks, @erkin --- I'm sure you can cherry-pick from 1.4 to 1.3; 'backporting' is not quite the right word, as it is development branch to stable branch. I really like this solution to the mess that was remote.py.

jestabro moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.
jestabro moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.