Validators + regex don't work together.
vyos@r2-roll# set protocols bgp 65001 neighbor 203.0.113.1 remote-as external 'external' is not a valid integer number [edit]
Description
Description
Details
Details
- Difficulty level
- Unknown (require assessment)
- Version
- VyOS 1.4-rolling-202102162107
- Why the issue appeared?
- Will be filled on close
- Is it a breaking change?
- Unspecified (possibly destroys the router)
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| In progress | FEATURE REQUEST | None | T3355 Remove all remaining legacy Vyatta code | ||
| Resolved | c-po | T2175 Rewriting all FRR processes allow for reloading and to XML/Python style | |||
| Resolved | FEATURE REQUEST | c-po | T2174 Rewrite protocol BGP to new XML/Python style | ||
| Duplicate | BUG | None | T3321 Bgp not possible to use internal|external remote as |
Event Timeline
Comment Actions
Well, they do work together.
vyos@vyos-test-2:~$ ${vyos_libexec_dir}/validate-value --regex '^(external|internal)$' --exec "${vyos_validators_dir}/numeric --range 1-4294967294" --value "external" && echo y
'external' is not a valid integer number
yBut there's a valid point here and in T2759, it prints a useless error message, and that's definitely a bug.