Page MenuHomeVyOS Platform
Create Task
Maniphest T3330

Bgp capability orf prefix-list fail
Closed, ResolvedPublicBUG
Actions

Description

To reproduce

set protocols bgp 64501 neighbor 203.0.113.1 remote-as '65001'
set protocols bgp 64501 neighbor 203.0.113.1 address-family ipv4-unicast capability orf prefix-list send

Commit

Traceback (most recent call last):
  File "/usr/libexec/vyos/conf_mode/protocols_bgp.py", line 197, in <module>
    apply(c)
  File "/usr/libexec/vyos/conf_mode/protocols_bgp.py", line 182, in apply
    frr_cfg.commit_configuration(frr_daemon)
  File "/usr/lib/python3/dist-packages/vyos/frr.py", line 442, in commit_configuration
    reload_configuration('\n'.join(self.config), daemon=daemon)
  File "/usr/lib/python3/dist-packages/vyos/frr.py", line 203, in reload_configuration
    raise CommitError(f'Configuration FRR failed while commiting code, please enabling debugging to examine logs')
vyos.frr.CommitError: Configuration FRR failed while commiting code, please enabling debugging to examine logs

Also, bug with receive

set protocols bgp 64501 neighbor 203.0.113.1 address-family ipv4-unicast capability orf prefix-list receive

Details

Difficulty level
Normal (likely a few hours)
Version
VyOS 1.4-rolling-202102162107
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible

Related Objects
Search...

Event Timeline

Viacheslav triaged this task as Normal priority.Feb 17 2021, 2:18 PM
Viacheslav created this task.
Viacheslav added a parent task: T2174: Rewrite protocol BGP to new XML/Python style.
Viacheslav updated the task description. (Show Details)Feb 17 2021, 2:22 PM
Viacheslav changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
pasik added a subscriber: pasik.Feb 17 2021, 5:36 PM
Viacheslav added a comment.Feb 19 2021, 11:25 AM

Template generate wrong value
https://github.com/vyos/vyos-1x/blob/current/data/templates/frr/bgp.frr.tmpl#L112

Feb 19 13:20:17 r4-roll commit_configuration[4048]: new_config  16  address-family ipv4 unicast
Feb 19 13:20:17 r4-roll commit_configuration[4048]: new_config  17   neighbor 203.0.113.1 capability orf prefix-list {'send': {}}
Viacheslav added a comment.Feb 19 2021, 12:03 PM

PR https://github.com/vyos/vyos-1x/pull/736

Viacheslav changed the task status from Open to Needs testing.Feb 19 2021, 5:19 PM
Viacheslav claimed this task.
c-po added a subscriber: c-po.Feb 19 2021, 7:20 PM

Can we also extend the available BGP smoketests to test this?

Viacheslav closed this task as Resolved.Feb 21 2021, 9:39 AM
c-po moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.May 24 2021, 7:39 PM