Page MenuHomeVyOS Platform

Bgp unsuppress-map should be as "value leafNode"
Closed, ResolvedPublicBUG

Description

Not possible to set value for unsuppress-map

set protocols bgp 64501 neighbor 203.0.113.1 remote-as '65001'
set protocols bgp 64501 neighbor 203.0.113.1 address-family ipv4-unicast unsuppress-map 
Possible completions:
  <Enter>	Execute the current command

We sent the wrong value for FRR

  neighbor 203.0.113.1 unsuppress-map {}
 exit-address-family
!

There is "valueless" parameter in the XML
https://github.com/vyos/vyos-1x/blob/current/interface-definitions/include/bgp-afi-common.xml.i#L135

Details

Difficulty level
Easy (less than an hour)
Version
VyOS 1.4-rolling-202102162107
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible

Event Timeline

Viacheslav triaged this task as Normal priority.Wed, Feb 17, 2:45 PM
Viacheslav created this task.
Viacheslav changed Difficulty level from Unknown (require assessment) to Easy (less than an hour).

PR https://github.com/vyos/vyos-1x/pull/735

set protocols bgp 64501 neighbor 203.0.113.1 address-family ipv4-unicast unsuppress-map 'FOO'
set protocols bgp 64501 neighbor 203.0.113.1 remote-as '65001'

Frr

 !
 address-family ipv4 unicast
  neighbor 203.0.113.1 unsuppress-map FOO
 exit-address-family
!
Viacheslav changed the task status from Open to Needs testing.Fri, Feb 19, 1:02 PM