Page MenuHomeVyOS Platform
Create Task
Maniphest T3362

1.3 - RC1 ifb redirect failing to commit
Closed, ResolvedPublicBUG
Actions

Description

trystan@shaper# compare
[edit interfaces]
+ethernet eth0 {
+ address dhcp
+ duplex full
+ firewall {
+ in {
+ name WAN_IN
+ }
+ local {
+ name WAN_LOCAL
+ }
+ }
+ hw-id <redacted>
+ mac <redacted>
+ policy {
+ }
+ redirect ifb0
+ speed 1000
+ traffic-policy {
+ out upload
+ }
+}
[edit]
trystan@shaper# commit
[ interfaces ethernet eth0 redirect ifb0 ]
Error: Exclusivity flag on, cannot modify.
tc qdisc ingress failed at /opt/vyatta/sbin/vyatta-qos.pl line 334.

interfaces ethernet eth0 failed
Commit failed
[edit]
trystan@shaper# exit

This was enough to leave my upgraded 1.2.6 -> 1.3 RC1 machine without an internet connection, that section/ifb redirect was working prior

Details

Difficulty level
Unknown (require assessment)
Version
RC1
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)

Event Timeline

trystan created this task.Feb 27 2021, 1:41 AM
Viacheslav added a subscriber: Viacheslav.Mar 7 2021, 6:55 PM

@trystan attach please configuration with sets, how to reproduce it.
For example

set param xxx option xxx..
set param2 xxx .option xxx..

And after commit... tc error..

It will be faster, to reproduce it.

Viacheslav added a comment.Mar 26 2021, 7:21 PM

@trystan Can you re-check it ?

trystan added a comment.Jun 17 2021, 3:46 AM

The same config now commits however the fq-codel shaper that was functional in 1.2.7 that's applied to it does not activate in 1.3.0-rc4

The config is taken right from the ifb0 fq-codel example on the wiki

'the case for ingress shaping'

https://docs.vyos.io/en/latest/configuration/trafficpolicy/index.html

pasik added a subscriber: pasik.Jun 17 2021, 6:58 AM
Viacheslav closed this task as Resolved.Sep 6 2021, 11:06 AM
Viacheslav claimed this task.
Viacheslav edited projects, added VyOS 1.3 Equuleus (1.3.0-epa1); removed VyOS 1.3 Equuleus.
Viacheslav moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.

Fixed VyOS 1.3-beta-202109060342

set interfaces ethernet eth0 redirect 'ifb0'
set interfaces input ifb0 traffic-policy out 'MY-INGRESS-SHAPING'
set traffic-policy shaper MY-INGRESS-SHAPING bandwidth '1000kbit'
set traffic-policy shaper MY-INGRESS-SHAPING default bandwidth '1000kbit'
set traffic-policy shaper MY-INGRESS-SHAPING default queue-type 'fair-queue'

Commit:

[email protected]# commit
[edit]
[email protected]# sudo iperf3 -c 192.168.122.11 -R
Connecting to host 192.168.122.11, port 5201
Reverse mode, remote host 192.168.122.11 is sending
[  5] local 192.168.122.14 port 52980 connected to 192.168.122.11 port 5201
[ ID] Interval           Transfer     Bitrate
[  5]   0.00-1.00   sec   119 KBytes   973 Kbits/sec                  
[  5]   1.00-2.00   sec   117 KBytes   961 Kbits/sec                  
[  5]   2.00-3.00   sec   117 KBytes   961 Kbits/sec                  
[  5]   3.00-4.00   sec   115 KBytes   938 Kbits/sec                  
^C[  5]   4.00-4.26   sec  29.7 KBytes   941 Kbits/sec                  
- - - - - - - - - - - - - - - - - - - - - - - - -
[ ID] Interval           Transfer     Bitrate
[  5]   0.00-4.26   sec  0.00 Bytes  0.00 bits/sec                  sender
[  5]   0.00-4.26   sec   498 KBytes   957 Kbits/sec                  receiver
iperf3: interrupt - the client has terminated
[edit]
[email protected]#