Page MenuHomeVyOS Platform

Extend the redirect_stdout context manager in vyos-configd to redirect stdout from subprocesses
Closed, ResolvedPublic

Description

In task T3302, stdout from conf_mode scripts called by vyos-configd was redirected to the console (or file, on boot) using the native Python contextmanager redirect_stdout. As understood, this contextmanager will only redirect stdout explicitly coming from the scripts themselves, and not that of any subbprocesses invoked --- however, capturing stdout from subprocesses is important, notably when debugging with, for example, vyos.ifconfig.debug. In this task, we provide a contextmanager to address this.

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Internal change (not visible to end users)

Event Timeline

jestabro changed the task status from Open to In progress.Mar 16 2021, 12:42 PM
jestabro triaged this task as High priority.
jestabro created this task.
jestabro created this object in space S1 VyOS Public.
jestabro changed the task status from Needs testing to Backport candidate.Mar 16 2021, 5:13 PM
jestabro moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.
jestabro moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.
SrividyaA set Issue type to Internal change (not visible to end users).Aug 31 2021, 2:54 PM