Page MenuHomeVyOS Platform

BGP Configuration Migration failed (badly!) from rolling 202102240218 to rolling 202104221210
Closed, ResolvedPublicBUG

Description

The change in syntax from:

protocols {
   bgp <ASN> {
...

to:

protocols {
   bgp {
      local-as <ASN>

did not happen automatically on my configuration and the failure was entirely silent.
As a result, after reboot, my router (which is remote and depended on BGP to be reachable)
ended up loading none of the BGP configuration stanzas and I have had to manually reconstruct
them from the pre-migration file.

Details

Difficulty level
Normal (likely a few hours)
Version
VyOS 1.4-rolling-202104221210 (upgrade process from 1.4-rolling-202102240218
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)

Event Timeline

Discussed on slack channel (#lobby) with @Christian Poessinger. He has the relevant original configuration file in PM.

Analysing the provided configuration file has shown that this is unrelated to the change. The supplied configuration used a non existing route-map/prefix list on the CLI. As this is now properly validated for existence the error was triggered.

The migrator could be extended to create prefix-lists/route-maps on bootip if they do not exist with a permit statement.

Workaround: ensure all prefix-lists/route-maps exist prior to upgrading.

It must be verified what FRR thinks about this when addin non existing maps and how that could work in the past, or got those maps simply skipped?

c-po triaged this task as Low priority.

Retested this with VyOS 1.3.0-rc3 and the bahavior is the same.

One can not set route-maps/prefix-lists that are non existent under the policy node. As the policy and protocols section had been under heavy rewrite during the time of your two ISO images you got lucky to pick a "not so good" one.

Closing this as "resolved"