Page MenuHomeVyOS Platform

Migrate loadkey command to op-mode
Closed, ResolvedPublic

Description

loadkey is a crufty old command that relies on bash functions and a messed up Vyatta script with barely functional curl subroutines. We should rewrite it in the modern Python/XML format.

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Behavior change
Issue type
Feature/functionality removal

Event Timeline

erkin triaged this task as Low priority.Apr 29 2021, 2:17 PM
erkin created this task.
erkin changed the task status from Open to In progress.May 30 2021, 10:21 AM
erkin raised the priority of this task from Low to Normal.
erkin changed the task status from In progress to On hold.Jun 23 2021, 8:49 AM

Done with generate public-key-command. loadkey is deprecated and will be removed in a future version.

From conf mode I get error VyOS 1.4-rolling-202108130117

vyos@vyos-oobm# loadkey vyos scp://[email protected]:/etc/ssh/ssh_host_rsa_key.pub
Global symbol "$generate" requires explicit package name (did you forget to declare "my $generate"?) at /opt/vyatta/sbin/vyatta-load-user-key.pl line 162.
Execution of /opt/vyatta/sbin/vyatta-load-user-key.pl aborted due to compilation errors.
[edit]
vyos@vyos-oobm#

I'm going to delete loadkey from 1.4 some time after 1.3 comes out.

erkin set Issue type to Feature/functionality removal.Dec 23 2021, 2:18 PM

I'm removing loadkey from 1.4. It will be removed from 1.3.1, as well. Eventually, the warning will be dropped from 1.4 but it will remain in 1.3.

Actually, let's leave it in 1.3 but backport the warning and generate public-key-command.

Removing the deprecation notice from 1.4.