Page MenuHomeVyOS Platform

BGP peer-group can't contain a hyphen
Closed, ResolvedPublicBUG

Description

To reproduce:

set protocols bgp local-as 100
set protocols bgp peer-group foo remote-as 200
set protocols bgp peer-group bar-baz remote-as 201
set protocols bgp peer-group bar_baz remote-as 201
set protocols bgp neighbor 192.0.2.1 peer-group foo
set protocols bgp neighbor 192.0.2.2 peer-group bar-baz
set protocols bgp neighbor 192.0.2.3 peer-group bar_baz

commit
[ protocols bgp neighbor 192.0.2.2 peer-group bar-baz ]
protocols bgp peer-group bar-baz doesn't exist

[[protocols bgp 100]] failed
Commit failed

FRR allows a peer-group to contain a hyphen

router bgp 100
 neighbor foo-bar peer-group
 neighbor foo-bar remote-as 200
 neighbor 1.1.1.1 peer-group foo-bar
!

VyOS 1.3 and older does not support this due to a regex when validating the peer-group name

[email protected]# set protocols bgp 100 peer-group bar-baz remote-as 201

  malformed peer-group name bar-baz

  Value validation failed
  Set failed

Details

Difficulty level
Unknown (require assessment)
Version
1.4-rolling
Why the issue appeared?
Implementation mistake
Is it a breaking change?
Perfectly compatible

Event Timeline

c-po created this task.
c-po added a project: VyOS 1.4 Sagitta.
c-po updated the task description. (Show Details)
c-po changed Version from 1.3.0-rc4 to 1.4-rolling.
c-po changed Why the issue appeared? from Will be filled on close to Implementation mistake.
c-po changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
c-po updated the task description. (Show Details)
c-po removed a project: VyOS 1.3 Equuleus.