Page MenuHomeVyOS Platform

Update to FastAPI causes regression in vyos-http-api-server
Closed, ResolvedPublicBUG

Description

FastAPI 0.65.2 checks Content-Type request header before assuming JSON, closing a well-known loophole. This requires a modification of the code providing backwards compatibility of multipart forms.. We will hold off on the update in 1.4 until resolved.

Details

Difficulty level
Normal (likely a few hours)
Version
vyos-1.4
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible

Event Timeline

jestabro triaged this task as Unbreak Now! priority.Jun 11 2021, 6:49 PM
jestabro created this task.
jestabro created this object in space S1 VyOS Public.
This comment was removed by jestabro.
jestabro lowered the priority of this task from Unbreak Now! to High.Jun 11 2021, 7:43 PM
jestabro updated the task description. (Show Details)
jestabro updated the task description. (Show Details)
jestabro changed Difficulty level from Unknown (require assessment) to Normal (likely a few hours).
jestabro changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.